third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp - Issue 2598353002: The second argument of add/removeEventListener should be an object, null, or undefined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp

Issue 2598353002: The second argument of add/removeEventListener should be an object, null, or undefined

Patch Set: Fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h ('k') | third_party/WebKit/Source/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp

index 198b07f0769d7698112ac98e8e21f05142080d21..d2f24e3b90bc11fbf8e805a43376c67fe26798ee 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp

@@ -40,7 +40,12 @@ EventListener* V8EventListenerHelper::getEventListener(

ScriptState* scriptState,

v8::Local<v8::Value> value,

bool isAttribute,

- ListenerLookupType lookup) {

+ ListenerLookupType lookup,

+ ExceptionState& exceptionState) {

+ if (!isUndefinedOrNull(value) && !value->IsObject()) {

+ exceptionState.throwTypeError("Cannot convert to EventListener.");

+ return nullptr;

+ }

if (lookup == ListenerFindOnly) {

// Used by EventTarget::removeEventListener, specifically

// EventTargetV8Internal::removeEventListenerMethod