Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h

Issue 2598353002: The second argument of add/removeEventListener should be an object, null, or undefined
Patch Set: Fix tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h
index e2df0f0e6fc9ec0e17b4465b7967d26e296e9657..7d579dc44acaf7d66d8861843b1725568b4dd596 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h
@@ -31,6 +31,7 @@
#ifndef V8EventListenerHelper_h
#define V8EventListenerHelper_h
+#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8EventListener.h"
#include "core/CoreExport.h"
@@ -70,7 +71,8 @@ class V8EventListenerHelper {
CORE_EXPORT static EventListener* getEventListener(ScriptState*,
v8::Local<v8::Value>,
bool isAttribute,
- ListenerLookupType);
+ ListenerLookupType,
+ ExceptionState&);
private:
static V8EventListener* findEventListener(

Powered by Google App Engine
This is Rietveld 408576698