Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 2598353002: The second argument of add/removeEventListener should be an object, null, or undefined
Patch Set: Fix tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
index 3b6c2df83f94cd21beeb68eb8040167ae23f16bb..9e758ee5f004ec6ebaba6b2b39824eef6c2c7d51 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
@@ -343,10 +343,11 @@ void ThreadDebugger::setMonitorEventsCallback(
if (!eventTarget)
return;
Vector<String> types = normalizeEventTypes(info);
+ NonThrowableExceptionState exceptionState;
EventListener* eventListener = V8EventListenerHelper::getEventListener(
ScriptState::current(info.GetIsolate()),
v8::Local<v8::Function>::Cast(info.Data()), false,
- enabled ? ListenerFindOrCreate : ListenerFindOnly);
+ enabled ? ListenerFindOrCreate : ListenerFindOnly, exceptionState);
if (!eventListener)
return;
for (size_t i = 0; i < types.size(); ++i) {
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698