third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 2598353002: The second argument of add/removeEventListener should be an object, null, or undefined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2598353002: The second argument of add/removeEventListener should be an object, null, or undefined

Patch Set: Fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index ec7af0a77932b25708de186b51475696705c99ab..fd08bdb6c57ce4791611886448fe608acf742292 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -516,7 +516,7 @@ def v8_conversion_needs_exception_state(idl_type):

return (idl_type.is_numeric_type or

idl_type.is_enum or

idl_type.is_dictionary or

- idl_type.name in ('Boolean', 'ByteString', 'Date', 'Dictionary', 'USVString', 'SerializedScriptValue'))

+ idl_type.name in ('Boolean', 'ByteString', 'Date', 'Dictionary', 'USVString', 'SerializedScriptValue', 'EventHandler'))

IdlType.v8_conversion_needs_exception_state = property(v8_conversion_needs_exception_state)

IdlArrayOrSequenceType.v8_conversion_needs_exception_state = True