third_party/WebKit/Source/bindings/scripts/v8_attributes.py - Issue 2598353002: The second argument of add/removeEventListener should be an object, null, or undefined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 2598353002: The second argument of add/removeEventListener should be an object, null, or undefined

Patch Set: Fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

index 006bc6c2f922a7704e40d6a53df32e2bb9a2f4dd..bcf3c511b5801645743c5ed97c1776172eb56dea 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

@@ -454,7 +454,7 @@ def setter_expression(interface, attribute, context):

arguments.append(

'V8EventListenerHelper::getEventListener(' +

'ScriptState::forReceiverObject(info), v8Value, true, ' +

- 'ListenerFindOrCreate)')

+ 'ListenerFindOrCreate, exceptionState)')

else:

arguments.append('cppValue')

if context['is_setter_raises_exception']: