mus: Use ui::ContextProviderCommandBuffer.

mus: Use ui::ContextProviderCommandBuffer.

Remove ui::ContextProvider and ui::GLES2Context, since they are incomplete.
Instead use ui::ContextProviderCommandBuffer, which is used by chrome browser
and renderers.

BUG=643746
TBR=jam@ for content/renderer for code update for API change

Committed: https://crrev.com/9f14d907cbfaa28b64223028d0ad27e3447e602d
Cr-Commit-Position: refs/heads/master@{#439718}

[sadrul, 2016-12-19 17:28:18]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 17:28:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 17:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 17:30:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[sadrul, 2016-12-19 17:37:19]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 17:37:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 19:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 19:30:42]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sadrul, 2016-12-19 19:57:44]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 19:58:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-19 20:10:43]

sadrul@chromium.org changed reviewers:
+ msw@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:13:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:13:20]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-12-19 21:24:01]

sadrul@chromium.org changed reviewers:
+ jbauman@chromium.org

[sadrul, 2016-12-19 21:24:02]

+jbauman@ too, especially for the change in gpu.cc

[msw, 2016-12-19 21:33:33]

I don't know this code well, but your changes seem reasonable. lgtm with nits

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
File services/ui/public/cpp/BUILD.gn (right):

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/BUILD.gn:34: "//mojo/public/cpp/system",
nit: no longer needed here?

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/BUILD.gn:114: "//mojo/public/cpp/system",
ditto nit

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
File services/ui/public/cpp/gpu/gpu.cc (right):

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/gpu/gpu.cc:72: constexpr
ui::ContextProviderCommandBuffer* shared_context_provider = nullptr;
optional nit: reorder after attributes to match param order?

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/gpu/gpu.cc:74: attributes.alpha_size = -1;
nit: this is the default; explicit assignment is not needed.

https://codereview.chromium.org/2586323002/diff/40001/ui/aura/mus/mus_context...
File ui/aura/mus/mus_context_factory.cc (right):

https://codereview.chromium.org/2586323002/diff/40001/ui/aura/mus/mus_context...
ui/aura/mus/mus_context_factory.cc:14: namespace {
tangential nit: remove empty anon namespace block

https://codereview.chromium.org/2586323002/diff/40001/ui/aura/mus/mus_context...
File ui/aura/mus/mus_context_factory.h (right):

https://codereview.chromium.org/2586323002/diff/40001/ui/aura/mus/mus_context...
ui/aura/mus/mus_context_factory.h:34: void
OnEstablishedGpuChannel(base::WeakPtr<ui::Compositor> compositor,
optional nit: comment?

https://codereview.chromium.org/2586323002/diff/40001/ui/aura/mus/mus_context...
ui/aura/mus/mus_context_factory.h:35: scoped_refptr<gpu::GpuChannelHost>
gpu_channel);
nit: include base/memory/ref_counted.h and base/memory/weak_ptr.h

[jbauman, 2016-12-19 22:16:22]

lgtm

[sadrul, 2016-12-20 03:53:02]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 03:53:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-20 03:53:20]

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
File services/ui/public/cpp/BUILD.gn (right):

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/BUILD.gn:34: "//mojo/public/cpp/system",
On 2016/12/19 21:33:33, msw wrote:
> nit: no longer needed here?

Done.

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/BUILD.gn:114: "//mojo/public/cpp/system",
On 2016/12/19 21:33:33, msw wrote:
> ditto nit

Done.

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
File services/ui/public/cpp/gpu/gpu.cc (right):

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/gpu/gpu.cc:72: constexpr
ui::ContextProviderCommandBuffer* shared_context_provider = nullptr;
On 2016/12/19 21:33:33, msw wrote:
> optional nit: reorder after attributes to match param order?

Done.

https://codereview.chromium.org/2586323002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/gpu/gpu.cc:74: attributes.alpha_size = -1;
On 2016/12/19 21:33:33, msw wrote:
> nit: this is the default; explicit assignment is not needed.

Good point. I have kept this for now though, since the current use in other
places seem to explicitly initialize it (e.g.
RenderThreadImpl::CreateCompositorFrameSink(), CreateOffscreenContext() etc.)

https://codereview.chromium.org/2586323002/diff/40001/ui/aura/mus/mus_context...
File ui/aura/mus/mus_context_factory.cc (right):

https://codereview.chromium.org/2586323002/diff/40001/ui/aura/mus/mus_context...
ui/aura/mus/mus_context_factory.cc:14: namespace {
On 2016/12/19 21:33:33, msw wrote:
> tangential nit: remove empty anon namespace block

Already done (landed in crrev.com/439651)

https://codereview.chromium.org/2586323002/diff/40001/ui/aura/mus/mus_context...
File ui/aura/mus/mus_context_factory.h (right):

https://codereview.chromium.org/2586323002/diff/40001/ui/aura/mus/mus_context...
ui/aura/mus/mus_context_factory.h:34: void
OnEstablishedGpuChannel(base::WeakPtr<ui::Compositor> compositor,
On 2016/12/19 21:33:33, msw wrote:
> optional nit: comment?

Done.

https://codereview.chromium.org/2586323002/diff/40001/ui/aura/mus/mus_context...
ui/aura/mus/mus_context_factory.h:35: scoped_refptr<gpu::GpuChannelHost>
gpu_channel);
On 2016/12/19 21:33:33, msw wrote:
> nit: include base/memory/ref_counted.h and base/memory/weak_ptr.h

Done.

[sadrul, 2016-12-20 04:08:31]

sadrul@chromium.org changed reviewers:
+ jam@chromium.org

[sadrul, 2016-12-20 04:08:32]

+jam@ for content/renderer (also will TBR since code update for API change)

[sadrul, 2016-12-20 04:34:24]

Description was changed from

==========
mus: Use ui::ContextProviderCommandBuffer.

Remove ui::ContextProvider and ui::GLES2Context, since they are incomplete.
Instead use ui::ContextProviderCommandBuffer, which is used by chrome browser
and renderers.

BUG=643746
==========

to

==========
mus: Use ui::ContextProviderCommandBuffer.

Remove ui::ContextProvider and ui::GLES2Context, since they are incomplete.
Instead use ui::ContextProviderCommandBuffer, which is used by chrome browser
and renderers.

BUG=643746
TBR=jam@ for content/renderer for code update for API change
==========

[sadrul, 2016-12-20 04:34:52]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-12-20 04:34:53]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2586323002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-12-20 04:34:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 05:47:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482208492522310,
"parent_rev": "e19ea5143216574b49a1a15937bb6175c57f9f9b", "commit_rev":
"4b702779c1dcc9e319c84bff65dd108034cf3328"}

[commit-bot: I haz the power, 2016-12-20 05:48:07]

Description was changed from

==========
mus: Use ui::ContextProviderCommandBuffer.

Remove ui::ContextProvider and ui::GLES2Context, since they are incomplete.
Instead use ui::ContextProviderCommandBuffer, which is used by chrome browser
and renderers.

BUG=643746
TBR=jam@ for content/renderer for code update for API change
==========

to

==========
mus: Use ui::ContextProviderCommandBuffer.

Remove ui::ContextProvider and ui::GLES2Context, since they are incomplete.
Instead use ui::ContextProviderCommandBuffer, which is used by chrome browser
and renderers.

BUG=643746
TBR=jam@ for content/renderer for code update for API change

Review-Url: https://codereview.chromium.org/2586323002
==========

[commit-bot: I haz the power, 2016-12-20 05:48:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-20 05:50:34]

Description was changed from

==========
mus: Use ui::ContextProviderCommandBuffer.

Remove ui::ContextProvider and ui::GLES2Context, since they are incomplete.
Instead use ui::ContextProviderCommandBuffer, which is used by chrome browser
and renderers.

BUG=643746
TBR=jam@ for content/renderer for code update for API change

Review-Url: https://codereview.chromium.org/2586323002
==========

to

==========
mus: Use ui::ContextProviderCommandBuffer.

Remove ui::ContextProvider and ui::GLES2Context, since they are incomplete.
Instead use ui::ContextProviderCommandBuffer, which is used by chrome browser
and renderers.

BUG=643746
TBR=jam@ for content/renderer for code update for API change

Committed: https://crrev.com/9f14d907cbfaa28b64223028d0ad27e3447e602d
Cr-Commit-Position: refs/heads/master@{#439718}
==========

[commit-bot: I haz the power, 2016-12-20 05:50:35]

Patchset 4 (id:??) landed as
https://crrev.com/9f14d907cbfaa28b64223028d0ad27e3447e602d
Cr-Commit-Position: refs/heads/master@{#439718}

[Fady Samuel, 2016-12-31 21:43:53]

On 2016/12/20 05:50:35, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/9f14d907cbfaa28b64223028d0ad27e3447e602d
> Cr-Commit-Position: refs/heads/master@{#439718}

Meta-API-boundary point:

   auto compositor_frame_sink = window->RequestCompositorFrameSink(
      compositor_frame_sink_type,
       gpu_->CreateContextProvider(gpu_->EstablishGpuChannelSync()),
       gpu_->gpu_memory_buffer_manager());

This API seems super weird. We are passing the Mus client library things it
should already know about! ui::Window (aura:Window now?) should know about gpu_,
it should know how to create a contextprovider, how to establish a gpu channel,
etc.

auto compositor_frame_sink = window->RequestCompositorFrameSink(); should be the
API to aspire for, in my opinion. WDYT?