Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2578743002: Add timeouts and unit tests to remote_client_grpc.py (Closed)

Created:
4 years ago by aludwin
Modified:
4 years ago
Reviewers:
ryanmartens, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, Eric Burnett, bergsieker_google.com
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add timeouts and unit tests to remote_client_grpc.py BUG= Review-Url: https://codereview.chromium.org/2578743002 Committed: https://github.com/luci/luci-py/commit/9c71f5b45ffd6f388b3914682ea3f320f072b167

Patch Set 1 #

Total comments: 6

Patch Set 2 : Response to maruel's comments on PS1 #

Messages

Total messages: 10 (5 generated)
aludwin
4 years ago (2016-12-14 21:07:35 UTC) #2
M-A Ruel
lgtm with minor style nits https://codereview.chromium.org/2578743002/diff/1/appengine/swarming/swarming_bot/bot_code/remote_client_grpc_test.py File appengine/swarming/swarming_bot/bot_code/remote_client_grpc_test.py (right): https://codereview.chromium.org/2578743002/diff/1/appengine/swarming/swarming_bot/bot_code/remote_client_grpc_test.py#newcode38 appengine/swarming/swarming_bot/bot_code/remote_client_grpc_test.py:38: inconsistent spacing between file ...
4 years ago (2016-12-14 21:21:52 UTC) #3
aludwin
https://codereview.chromium.org/2578743002/diff/1/appengine/swarming/swarming_bot/bot_code/remote_client_grpc_test.py File appengine/swarming/swarming_bot/bot_code/remote_client_grpc_test.py (right): https://codereview.chromium.org/2578743002/diff/1/appengine/swarming/swarming_bot/bot_code/remote_client_grpc_test.py#newcode38 appengine/swarming/swarming_bot/bot_code/remote_client_grpc_test.py:38: On 2016/12/14 21:21:52, M-A Ruel wrote: > inconsistent spacing ...
4 years ago (2016-12-14 22:10:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578743002/20001
4 years ago (2016-12-14 22:10:25 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-14 22:14:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/9c71f5b45ffd6f388b3914682ea3f320f072b167

Powered by Google App Engine
This is Rietveld 408576698