Use config.json to enable Isolated gRPC proxy

Use config.json to enable Isolated gRPC proxy

The values in config.json are not set yet and will be added in a future
change.

BUG=

Review-Url: https://codereview.chromium.org/2969463002
Committed: https://github.com/luci/luci-py/commit/33233c3d9841007f0e3a46f8b0300982b0bc3a53

[aludwin, 2017-06-29 18:38:44]

aludwin@google.com changed reviewers:
+ ryanmartens@google.com, vadimsh@chromium.org

[aludwin, 2017-06-29 18:38:45]

This code isn't active yet (except for the env var override in bot_main.py)
since I'm trying to break these changes into smaller chunks. The next step is to
add an isolate_grpc_proxy into settings.cfg, and pass that into the bot's
config.json file.

[Vadim Sh., 2017-06-29 19:00:18]

https://codereview.chromium.org/2969463002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/bot_code/bot_main.py (right):

https://codereview.chromium.org/2969463002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/bot_main.py:588: grpc_proxy =
get_config().get('isolate-grpc-proxy')
use underscores, so it is a valid proto field name: isolate_grpc_proxy (I think
eventually config.json is assembled form a proto message)

Also other config.json fields use underscores now.

https://codereview.chromium.org/2969463002/diff/1/client/isolateserver.py
File client/isolateserver.py (right):

https://codereview.chromium.org/2969463002/diff/1/client/isolateserver.py#new...
client/isolateserver.py:1969: if options.grpc_proxy is not None:
just 'if options.grpc_proxy'

I think it can be empty string too (depends on how option parser works)

[aludwin, 2017-06-29 19:14:30]

https://codereview.chromium.org/2969463002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/bot_code/bot_main.py (right):

https://codereview.chromium.org/2969463002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/bot_main.py:588: grpc_proxy =
get_config().get('isolate-grpc-proxy')
On 2017/06/29 19:00:18, Vadim Sh. wrote:
> use underscores, so it is a valid proto field name: isolate_grpc_proxy (I
think
> eventually config.json is assembled form a proto message)
> 
> Also other config.json fields use underscores now.

Done.

https://codereview.chromium.org/2969463002/diff/1/client/isolateserver.py
File client/isolateserver.py (right):

https://codereview.chromium.org/2969463002/diff/1/client/isolateserver.py#new...
client/isolateserver.py:1969: if options.grpc_proxy is not None:
On 2017/06/29 19:00:18, Vadim Sh. wrote:
> just 'if options.grpc_proxy'
> 
> I think it can be empty string too (depends on how option parser works)

Done.

[Vadim Sh., 2017-06-29 20:57:54]

lgtm

[aludwin, 2017-06-29 21:10:59]

The CQ bit was checked by aludwin@google.com

[commit-bot: I haz the power, 2017-06-29 21:11:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 21:19:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 21:19:18]

Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/370e86d210510010)

[aludwin, 2017-06-29 23:34:31]

The CQ bit was checked by aludwin@google.com

[aludwin, 2017-06-29 23:34:31]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2969463002/#ps60001
(title: "Fix pylint errors")

[commit-bot: I haz the power, 2017-06-29 23:34:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 23:38:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498779271380630,
"parent_rev": "18a465acbf169f8b46d813733748bf38493eb68c", "commit_rev":
"33233c3d9841007f0e3a46f8b0300982b0bc3a53"}

[commit-bot: I haz the power, 2017-06-29 23:38:54]

Description was changed from

==========
Use config.json to enable Isolated gRPC proxy

The values in config.json are not set yet and will be added in a future
change.

BUG=
==========

to

==========
Use config.json to enable Isolated gRPC proxy

The values in config.json are not set yet and will be added in a future
change.

BUG=

Review-Url: https://codereview.chromium.org/2969463002
Committed:
https://github.com/luci/luci-py/commit/33233c3d9841007f0e3a46f8b0300982b0bc3a53
==========

[commit-bot: I haz the power, 2017-06-29 23:38:55]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-py/commit/33233c3d9841007f0e3a46f8b0300982b0bc3a53