Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2755443002: Deep copy any proto values that might outlive the message (Closed)

Created:
3 years, 9 months ago by aludwin
Modified:
3 years, 9 months ago
Reviewers:
ryanmartens, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Deep copy any proto values that might outlive the message BUG= Review-Url: https://codereview.chromium.org/2755443002 Committed: https://github.com/luci/luci-py/commit/b62db339de0205127b13fc51d5f8e23a487f40ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M appengine/swarming/swarming_bot/bot_code/remote_client_grpc.py View 4 chunks +7 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
aludwin
Just realized I never submitted this one!
3 years, 9 months ago (2017-03-14 13:45:58 UTC) #2
M-A Ruel
lgtm
3 years, 9 months ago (2017-03-14 14:15:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755443002/1
3 years, 9 months ago (2017-03-14 14:17:14 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 14:20:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/b62db339de0205127b13fc51d5f8e23a487f40ba

Powered by Google App Engine
This is Rietveld 408576698