Add a default Isolate gRPC proxy in config

Add a default Isolate gRPC proxy in config

Also removed the old is_grpc flag from the bot's config.json and (rather
than removing all traces) prepared for the eventual swarming_grpc_proxy
flag that will also be added.

Tested: deployed a new settings.cfg with the new value filled in and
confirmed that the appropriate debug message is printed and the bot
correctly contacts the proxy (w/o setting the env var override).
Review-Url: https://codereview.chromium.org/2969513002
Committed: https://github.com/luci/luci-py/commit/68d95d9e6f045e653ae28e36865c7974f9dbeb7b

[aludwin, 2017-06-29 20:29:51]

Note: this depends on https://codereview.chromium.org/2969463002/ (that's
***46***3002, not ***51***3002, which is this change). However, Rietveld didn't
pick that up and I'm not sure why, so some changes from that CL show up in this
review for some reason.

[aludwin, 2017-06-29 20:30:37]

aludwin@google.com changed reviewers:
+ ryanmartens@google.com, vadimsh@chromium.org

[aludwin, 2017-06-29 20:30:38]

Note: this depends on https://codereview.chromium.org/2969463002/ (that's
***46***3002, not ***51***3002, which is this change). However, Rietveld didn't
pick that up and I'm not sure why, so some changes from that CL show up in this
review for some reason.

[Vadim Sh., 2017-06-29 21:56:23]

lgtm with nit

https://codereview.chromium.org/2969513002/diff/20001/appengine/swarming/hand...
File appengine/swarming/handlers_bot.py (right):

https://codereview.chromium.org/2969513002/diff/20001/appengine/swarming/hand...
appengine/swarming/handlers_bot.py:95: def get_bot_contact_server(request):
can we remove this function now?

[aludwin, 2017-06-29 23:38:58]

https://codereview.chromium.org/2969513002/diff/20001/appengine/swarming/hand...
File appengine/swarming/handlers_bot.py (right):

https://codereview.chromium.org/2969513002/diff/20001/appengine/swarming/hand...
appengine/swarming/handlers_bot.py:95: def get_bot_contact_server(request):
On 2017/06/29 21:56:23, Vadim Sh. wrote:
> can we remove this function now?

Done.

[Vadim Sh., 2017-06-30 00:02:01]

lgtm

[aludwin, 2017-06-30 15:39:43]

The CQ bit was checked by aludwin@google.com

[aludwin, 2017-06-30 15:39:43]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2969513002/#ps60001
(title: "Remove uncalled fn")

[commit-bot: I haz the power, 2017-06-30 15:39:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 15:47:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 15:47:41]

Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/37127d90958ff810)

[aludwin, 2017-06-30 16:05:23]

Vadim - I had to make a change to bot_archive to allow a None to be passed in
for settings. I'm submitting this change since I think it's still in the spirit
of what you approved but if you have any concerns please let me know and I'll
make any required followup fixes.

[aludwin, 2017-06-30 16:09:42]

The CQ bit was checked by aludwin@google.com

[aludwin, 2017-06-30 16:09:42]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2969513002/#ps80001
(title: "Fix problem in tests")

[commit-bot: I haz the power, 2017-06-30 16:09:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 16:14:22]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498838982382560,
"parent_rev": "40e34056876a9c6cae4002aefbfa09da9929045c", "commit_rev":
"68d95d9e6f045e653ae28e36865c7974f9dbeb7b"}

[commit-bot: I haz the power, 2017-06-30 16:14:25]

Description was changed from

==========
Add a default Isolate gRPC proxy in config

Also removed the old is_grpc flag from the bot's config.json and (rather
than removing all traces) prepared for the eventual swarming_grpc_proxy
flag that will also be added.

Tested: deployed a new settings.cfg with the new value filled in and
confirmed that the appropriate debug message is printed and the bot
correctly contacts the proxy (w/o setting the env var override).
==========

to

==========
Add a default Isolate gRPC proxy in config

Also removed the old is_grpc flag from the bot's config.json and (rather
than removing all traces) prepared for the eventual swarming_grpc_proxy
flag that will also be added.

Tested: deployed a new settings.cfg with the new value filled in and
confirmed that the appropriate debug message is printed and the bot
correctly contacts the proxy (w/o setting the env var override).
Review-Url: https://codereview.chromium.org/2969513002
Committed:
https://github.com/luci/luci-py/commit/68d95d9e6f045e653ae28e36865c7974f9dbeb7b
==========

[commit-bot: I haz the power, 2017-06-30 16:14:26]

Committed patchset #5 (id:80001) as
https://github.com/luci/luci-py/commit/68d95d9e6f045e653ae28e36865c7974f9dbeb7b