Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2599493002: Rethrow Isolate gRPC proxy exceptions as IOError (Closed)

Created:
3 years, 12 months ago by aludwin
Modified:
3 years, 12 months ago
Reviewers:
ryanmartens, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -28 lines) Patch
M client/isolate_storage.py View 3 chunks +27 lines, -13 lines 0 comments Download
M client/tests/isolate_storage_test.py View 4 chunks +63 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
aludwin
Ensures that all gRPC errors are converted to IOError. My understanding is that this will ...
3 years, 12 months ago (2016-12-21 17:26:16 UTC) #2
M-A Ruel
lgtm
3 years, 12 months ago (2016-12-21 17:30:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599493002/1
3 years, 12 months ago (2016-12-21 18:02:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599493002/1
3 years, 12 months ago (2016-12-21 18:27:19 UTC) #8
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 18:36:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/71a0a2d56a38116fe36a07c8a03851c0b2a51e3e

Powered by Google App Engine
This is Rietveld 408576698