Split //ios/chrome/browser/prefs to prevent circular dependencies.

Split //ios/chrome/browser/prefs to prevent circular dependencies.

Having ios/chrome/browser/prefs/browser_prefs.h part of the target
will cause circular dependency when downstream code is upstreamed,
so split to a separate target in preparation.

Clean some forwarding-include in ios/chrome/browser/pref_names.h.

BUG=663469
Committed: https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8
Cr-Commit-Position: refs/heads/master@{#438535}

[sdefresne, 2016-12-14 14:40:57]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 14:41:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-14 14:49:16]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2016-12-14 14:49:16]

Please take a look.

[rohitrao (ping after 24h), 2016-12-14 14:54:03]

lgtm

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/browser_...
File ios/chrome/browser/browser_state/BUILD.gn (right):

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/browser_...
ios/chrome/browser/browser_state/BUILD.gn:111:
"//ios/chrome/browser/prefs:browser_prefs",
Sorting?

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/device_s...
File ios/chrome/browser/device_sharing/device_sharing_manager.mm (right):

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/device_s...
ios/chrome/browser/device_sharing/device_sharing_manager.mm:15: #include
"ios/chrome/browser/pref_names.h"
Can this be removed?

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/device_s...
File ios/chrome/browser/device_sharing/device_sharing_manager_unittest.mm
(right):

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/device_s...
ios/chrome/browser/device_sharing/device_sharing_manager_unittest.mm:15:
#include "ios/chrome/browser/pref_names.h"
Can this be removed?

[commit-bot: I haz the power, 2016-12-14 15:18:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 15:18:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sdefresne, 2016-12-14 15:57:44]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 15:57:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-14 15:58:03]

Thank you for the review.

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/browser_...
File ios/chrome/browser/browser_state/BUILD.gn (right):

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/browser_...
ios/chrome/browser/browser_state/BUILD.gn:111:
"//ios/chrome/browser/prefs:browser_prefs",
On 2016/12/14 14:54:03, rohitrao wrote:
> Sorting?

I expected "gn format" to have sorted everything. Done.

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/device_s...
File ios/chrome/browser/device_sharing/device_sharing_manager.mm (right):

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/device_s...
ios/chrome/browser/device_sharing/device_sharing_manager.mm:15: #include
"ios/chrome/browser/pref_names.h"
On 2016/12/14 14:54:03, rohitrao wrote:
> Can this be removed?

Done.

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/device_s...
File ios/chrome/browser/device_sharing/device_sharing_manager_unittest.mm
(right):

https://codereview.chromium.org/2574213002/diff/1/ios/chrome/browser/device_s...
ios/chrome/browser/device_sharing/device_sharing_manager_unittest.mm:15:
#include "ios/chrome/browser/pref_names.h"
On 2016/12/14 14:54:03, rohitrao wrote:
> Can this be removed?

Done.

[sdefresne, 2016-12-14 16:06:18]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-12-14 16:06:21]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-12-14 16:06:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2574213002/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-12-14 16:06:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 16:59:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481731581640260,
"parent_rev": "9c4b765b73252f5b04bf2e776d280ef17040c549", "commit_rev":
"703dbda49828ab612fef8c803fd6668aa4da2ec6"}

[commit-bot: I haz the power, 2016-12-14 17:00:09]

Description was changed from

==========
Split //ios/chrome/browser/prefs to prevent circular dependencies.

Having ios/chrome/browser/prefs/browser_prefs.h part of the target
will cause circular dependency when downstream code is upstreamed,
so split to a separate target in preparation.

Clean some forwarding-include in ios/chrome/browser/pref_names.h.

BUG=663469
==========

to

==========
Split //ios/chrome/browser/prefs to prevent circular dependencies.

Having ios/chrome/browser/prefs/browser_prefs.h part of the target
will cause circular dependency when downstream code is upstreamed,
so split to a separate target in preparation.

Clean some forwarding-include in ios/chrome/browser/pref_names.h.

BUG=663469

Review-Url: https://codereview.chromium.org/2574213002
==========

[commit-bot: I haz the power, 2016-12-14 17:00:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 17:03:13]

Description was changed from

==========
Split //ios/chrome/browser/prefs to prevent circular dependencies.

Having ios/chrome/browser/prefs/browser_prefs.h part of the target
will cause circular dependency when downstream code is upstreamed,
so split to a separate target in preparation.

Clean some forwarding-include in ios/chrome/browser/pref_names.h.

BUG=663469

Review-Url: https://codereview.chromium.org/2574213002
==========

to

==========
Split //ios/chrome/browser/prefs to prevent circular dependencies.

Having ios/chrome/browser/prefs/browser_prefs.h part of the target
will cause circular dependency when downstream code is upstreamed,
so split to a separate target in preparation.

Clean some forwarding-include in ios/chrome/browser/pref_names.h.

BUG=663469

Committed: https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8
Cr-Commit-Position: refs/heads/master@{#438535}
==========

[commit-bot: I haz the power, 2016-12-14 17:03:14]

Patchset 2 (id:??) landed as
https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8
Cr-Commit-Position: refs/heads/master@{#438535}