Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2571113003: Merge //ios/chrome/browser/ui:{ui,ui_arc} targets. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge //ios/chrome/browser/ui:{ui,ui_arc} targets. Both target now use ARC, so merge them into a single target in preparation of upstreaming. BUG=None Committed: https://crrev.com/dbd5d094fc2be9152e712a76308768f516fa5dbe Cr-Commit-Position: refs/heads/master@{#438515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 3 chunks +3 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-12-14 13:18:55 UTC) #4
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-14 13:23:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571113003/1
4 years ago (2016-12-14 14:40:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 14:44:38 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 14:48:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbd5d094fc2be9152e712a76308768f516fa5dbe
Cr-Commit-Position: refs/heads/master@{#438515}

Powered by Google App Engine
This is Rietveld 408576698