ios/chrome/browser/browser_state/BUILD.gn - Issue 2574213002: Split //ios/chrome/browser/prefs to prevent circular dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/browser_state/BUILD.gn

Issue 2574213002: Split //ios/chrome/browser/prefs to prevent circular dependencies. (Closed)

Patch Set: Address comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/browser_state/BUILD.gn

diff --git a/ios/chrome/browser/browser_state/BUILD.gn b/ios/chrome/browser/browser_state/BUILD.gn

index 50c1e4f7d79d4a183d8341d6c971f05afd96c615..ff04e6ea4d2dfb203bd70583207f8a8d3897961c 100644

--- a/ios/chrome/browser/browser_state/BUILD.gn

+++ b/ios/chrome/browser/browser_state/BUILD.gn

@@ -89,6 +89,7 @@ source_set("browser_state_impl") {

"//ios/chrome/browser/ntp_snippets",

"//ios/chrome/browser/passwords",

"//ios/chrome/browser/prefs",

+ "//ios/chrome/browser/prefs:browser_prefs",

"//ios/chrome/browser/reading_list",

"//ios/chrome/browser/search_engines",

"//ios/chrome/browser/services/gcm",

@@ -109,7 +110,7 @@ source_set("browser_state_impl") {

"//ios/chrome/browser",

"//ios/chrome/browser/browser_state_metrics",

"//ios/chrome/browser/net",

- "//ios/chrome/browser/prefs",

+ "//ios/chrome/browser/prefs:browser_prefs",

"//ios/chrome/browser/signin",

"//ios/chrome/browser/sync",

"//ios/chrome/browser/sync/glue",

@@ -146,6 +147,7 @@ source_set("test_support") {

"//ios/chrome/browser/history",

"//ios/chrome/browser/net",

"//ios/chrome/browser/prefs",

+ "//ios/chrome/browser/prefs:browser_prefs",

"//ios/chrome/browser/sync/glue",

"//ios/chrome/test:test_support",

"//ios/public/provider/chrome/browser",

« no previous file with comments | « ios/chrome/browser/BUILD.gn ('k') | ios/chrome/browser/device_sharing/BUILD.gn » ('j') | no next file with comments »