Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: ios/chrome/browser/prefs/BUILD.gn

Issue 2574213002: Split //ios/chrome/browser/prefs to prevent circular dependencies. (Closed)
Patch Set: Address comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/pref_names.h ('k') | ios/chrome/browser/signin/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/prefs/BUILD.gn
diff --git a/ios/chrome/browser/prefs/BUILD.gn b/ios/chrome/browser/prefs/BUILD.gn
index 459855a698bad013bb0bd415e58af8b0751846e3..84c6e4ad7f7c3085a77291f46801b9c55f2a7cf7 100644
--- a/ios/chrome/browser/prefs/BUILD.gn
+++ b/ios/chrome/browser/prefs/BUILD.gn
@@ -4,8 +4,6 @@
source_set("prefs") {
sources = [
- "browser_prefs.h",
- "browser_prefs.mm",
"ios_chrome_pref_model_associator_client.cc",
"ios_chrome_pref_model_associator_client.h",
"ios_chrome_pref_service_factory.cc",
@@ -15,6 +13,26 @@ source_set("prefs") {
]
deps = [
"//base",
+ "//components/content_settings/core/browser",
+ "//components/prefs",
+ "//components/proxy_config",
+ "//components/search_engines",
+ "//components/sync_preferences",
+ "//ios/chrome/browser",
+ ]
+
+ # TODO(sdefresne): remove once downstream dependencies have been fixed.
+ public_deps = [
+ ":browser_prefs",
+ ]
+}
+
+source_set("browser_prefs") {
+ sources = [
+ "browser_prefs.h",
+ "browser_prefs.mm",
+ ]
+ deps = [
"//components/autofill/core/browser",
"//components/browsing_data/core",
"//components/content_settings/core/browser",
@@ -36,7 +54,6 @@ source_set("prefs") {
"//components/ssl_config",
"//components/strings",
"//components/sync",
- "//components/sync_preferences",
"//components/translate/core/browser",
"//components/translate/core/common",
"//components/update_client",
@@ -50,7 +67,6 @@ source_set("prefs") {
"//ios/chrome/browser/metrics",
"//ios/chrome/browser/net",
"//ios/chrome/browser/physical_web",
- "//ios/chrome/browser/reading_list",
"//ios/chrome/browser/signin",
"//ios/chrome/browser/voice:prefs",
"//ios/public/provider/chrome/browser",
« no previous file with comments | « ios/chrome/browser/pref_names.h ('k') | ios/chrome/browser/signin/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698