Split //ios/chrome/browser/prefs to prevent circular dependencies.

ios/chrome/browser/browser_state/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 source_set("browser_state") {
   sources = [
     "browser_state_otr_helper.cc",
     "browser_state_otr_helper.h",
     "chrome_browser_state.h",
     "chrome_browser_state.mm",
@@ skipping 71 matching lines @@
     "//ios/chrome/browser/dom_distiller",
     "//ios/chrome/browser/favicon",
     "//ios/chrome/browser/google",
     "//ios/chrome/browser/google:google_logo",
     "//ios/chrome/browser/history",
     "//ios/chrome/browser/invalidation",
     "//ios/chrome/browser/net",
     "//ios/chrome/browser/ntp_snippets",
     "//ios/chrome/browser/passwords",
     "//ios/chrome/browser/prefs",
+    "//ios/chrome/browser/prefs:browser_prefs",
     "//ios/chrome/browser/reading_list",
     "//ios/chrome/browser/search_engines",
     "//ios/chrome/browser/services/gcm",
     "//ios/chrome/browser/signin",
     "//ios/chrome/browser/suggestions",
     "//ios/chrome/browser/sync",
     "//ios/chrome/browser/sync/glue",
     "//ios/chrome/browser/translate",
     "//ios/chrome/browser/undo",
     "//ios/net",
     "//ios/public/provider/chrome/browser",
     "//ios/public/provider/chrome/browser/signin",
     "//ios/web",
     "//net",
     "//net:extras",
   ]
   allow_circular_includes_from = [
     "//ios/chrome/browser",
+    "//ios/chrome/browser/prefs:browser_prefs",

[rohitrao (ping after 24h), 2016/12/14 14:54:03]

Sorting?

[sdefresne, 2016/12/14 15:58:03]

I expected "gn format" to have sorted everything. Done.

     "//ios/chrome/browser/browser_state_metrics",
     "//ios/chrome/browser/net",
-    "//ios/chrome/browser/prefs",
     "//ios/chrome/browser/signin",
     "//ios/chrome/browser/sync",
     "//ios/chrome/browser/sync/glue",
   ]
 }
 
 source_set("test_support") {
   testonly = true
   sources = [
     "test_chrome_browser_state.h",
@@ skipping 16 matching lines @@
     "//components/sync_preferences",
     "//components/sync_preferences:test_support",
     "//components/user_prefs",
     "//components/webdata_services",
     "//ios/chrome/browser",
     "//ios/chrome/browser/autocomplete",
     "//ios/chrome/browser/bookmarks",
     "//ios/chrome/browser/history",
     "//ios/chrome/browser/net",
     "//ios/chrome/browser/prefs",
+    "//ios/chrome/browser/prefs:browser_prefs",
     "//ios/chrome/browser/sync/glue",
     "//ios/chrome/test:test_support",
     "//ios/public/provider/chrome/browser",
     "//ios/public/provider/chrome/browser/ui",
     "//ios/web",
     "//net:test_support",
   ]
 
   configs += [ "//build/config/compiler:enable_arc" ]
 }