Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257393004: Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL (Closed)

Created:
6 years, 7 months ago by bsalomon
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL Committed: http://code.google.com/p/skia/source/detail?r=14460

Patch Set 1 #

Patch Set 2 : whitespace change #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -96 lines) Patch
M bench/GrResourceCacheBench.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M include/core/SkTypes.h View 1 1 chunk +2 lines, -0 lines 3 comments Download
M include/gpu/GrColor.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrConfig.h View 1 chunk +0 lines, -9 lines 0 comments Download
M include/gpu/GrContextFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrTypesPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrCacheID.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrStencil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextureAccess.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGrFontScaler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLSL.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLVertexEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
There are some GrCrash's that need to turn into GrCrashIfNotChromium. They check things that should ...
6 years, 7 months ago (2014-04-30 13:45:27 UTC) #1
mtklein
https://codereview.chromium.org/257393004/diff/20001/include/core/SkTypes.h File include/core/SkTypes.h (right): https://codereview.chromium.org/257393004/diff/20001/include/core/SkTypes.h#newcode116 include/core/SkTypes.h:116: #define SkFAIL(message) SK_DEBUGBREAK(false && message) Isn't this the same ...
6 years, 7 months ago (2014-04-30 13:51:37 UTC) #2
reed1
lgtm https://codereview.chromium.org/257393004/diff/20001/include/core/SkTypes.h File include/core/SkTypes.h (right): https://codereview.chromium.org/257393004/diff/20001/include/core/SkTypes.h#newcode116 include/core/SkTypes.h:116: #define SkFAIL(message) SK_DEBUGBREAK(false && message) On 2014/04/30 13:51:37, ...
6 years, 7 months ago (2014-04-30 14:01:28 UTC) #3
bsalomon
https://codereview.chromium.org/257393004/diff/20001/include/core/SkTypes.h File include/core/SkTypes.h (right): https://codereview.chromium.org/257393004/diff/20001/include/core/SkTypes.h#newcode116 include/core/SkTypes.h:116: #define SkFAIL(message) SK_DEBUGBREAK(false && message) On 2014/04/30 13:51:37, mtklein ...
6 years, 7 months ago (2014-04-30 14:01:44 UTC) #4
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-04-30 14:09:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/257393004/20001
6 years, 7 months ago (2014-04-30 14:09:51 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 14:17:27 UTC) #7
Message was sent while issue was closed. 
Change committed as 14460

Powered by Google App Engine
This is Rietveld 408576698