include/core/SkTypes.h - Issue 257393004: Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTypes.h

Issue 257393004: Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: whitespace change Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkTypes.h

diff --git a/include/core/SkTypes.h b/include/core/SkTypes.h

index 13450cd0117585084f6a8ca7cc7affe4a9261abf..8863b07326558b310119e5485dc2e5ec9ebaa289 100644

--- a/include/core/SkTypes.h

+++ b/include/core/SkTypes.h

@@ -113,6 +113,8 @@ inline void operator delete(void* p) {

#define SkAssertResult(cond) cond

#endif

+#define SkFAIL(message) SK_DEBUGBREAK(false && message)

mtklein 2014/04/30 13:51:37 Isn't this the same as SkDEBUGFAIL?

reed1 2014/04/30 14:01:28 I think SkDEBUGFAIL does nothing in a release buil

bsalomon 2014/04/30 14:01:44 SK_DEBUGBREAK is misnamed. It is really SK_ALWAYSB

#ifdef SK_DEVELOPER

#define SkDEVCODE(code) code

#else

« no previous file with comments | « bench/GrResourceCacheBench.cpp ('k') | include/gpu/GrColor.h » ('j') | no next file with comments »