Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: include/core/SkTypes.h

Issue 257393004: Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: whitespace change Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « bench/GrResourceCacheBench.cpp ('k') | include/gpu/GrColor.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2006 The Android Open Source Project 2 * Copyright 2006 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkTypes_DEFINED 8 #ifndef SkTypes_DEFINED
9 #define SkTypes_DEFINED 9 #define SkTypes_DEFINED
10 10
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 #define SkDEBUGFAIL(message) 106 #define SkDEBUGFAIL(message)
107 #define SkDEBUGCODE(code) 107 #define SkDEBUGCODE(code)
108 #define SkDEBUGF(args) 108 #define SkDEBUGF(args)
109 #define SkDECLAREPARAM(type, var) 109 #define SkDECLAREPARAM(type, var)
110 #define SkPARAM(var) 110 #define SkPARAM(var)
111 111
112 // unlike SkASSERT, this guy executes its condition in the non-debug build 112 // unlike SkASSERT, this guy executes its condition in the non-debug build
113 #define SkAssertResult(cond) cond 113 #define SkAssertResult(cond) cond
114 #endif 114 #endif
115 115
116 #define SkFAIL(message) SK_DEBUGBREAK(false && message)
mtklein 2014/04/30 13:51:37 Isn't this the same as SkDEBUGFAIL?
reed1 2014/04/30 14:01:28 I think SkDEBUGFAIL does nothing in a release buil
bsalomon 2014/04/30 14:01:44 SK_DEBUGBREAK is misnamed. It is really SK_ALWAYSB
117
116 #ifdef SK_DEVELOPER 118 #ifdef SK_DEVELOPER
117 #define SkDEVCODE(code) code 119 #define SkDEVCODE(code) code
118 #else 120 #else
119 #define SkDEVCODE(code) 121 #define SkDEVCODE(code)
120 #endif 122 #endif
121 123
122 #ifdef SK_IGNORE_TO_STRING 124 #ifdef SK_IGNORE_TO_STRING
123 #define SK_TO_STRING_NONVIRT() 125 #define SK_TO_STRING_NONVIRT()
124 #define SK_TO_STRING_VIRT() 126 #define SK_TO_STRING_VIRT()
125 #define SK_TO_STRING_PUREVIRT() 127 #define SK_TO_STRING_PUREVIRT()
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
655 private: 657 private:
656 void* fPtr; 658 void* fPtr;
657 size_t fSize; // can be larger than the requested size (see kReuse) 659 size_t fSize; // can be larger than the requested size (see kReuse)
658 uint32_t fStorage[(kSize + 3) >> 2]; 660 uint32_t fStorage[(kSize + 3) >> 2];
659 }; 661 };
660 // Can't guard the constructor because it's a template class. 662 // Can't guard the constructor because it's a template class.
661 663
662 #endif /* C++ */ 664 #endif /* C++ */
663 665
664 #endif 666 #endif
OLDNEW
« no previous file with comments | « bench/GrResourceCacheBench.cpp ('k') | include/gpu/GrColor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698