src/effects/SkMorphologyImageFilter.cpp - Issue 257393004: Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMorphologyImageFilter.cpp

Issue 257393004: Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: whitespace change Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMorphologyImageFilter.cpp

diff --git a/src/effects/SkMorphologyImageFilter.cpp b/src/effects/SkMorphologyImageFilter.cpp

index 2350e6c29ebdf1c37c4a4d3f4eeb00d8562c16b3..8803f8aae39706388f1a6bee6305d9f1c4f028d8 100644

--- a/src/effects/SkMorphologyImageFilter.cpp

+++ b/src/effects/SkMorphologyImageFilter.cpp

@@ -369,7 +369,7 @@ void GrGLMorphologyEffect::emitCode(GrGLShaderBuilder* builder,

func = "max";

break;

default:

- GrCrash("Unexpected type");

+ SkFAIL("Unexpected type");

func = ""; // suppress warning

break;

}

@@ -410,7 +410,7 @@ void GrGLMorphologyEffect::setData(const GrGLUniformManager& uman,

imageIncrement[1] = 1.0f / texture.height();

break;

default:

- GrCrash("Unknown filter direction.");

+ SkFAIL("Unknown filter direction.");

}

uman.set2fv(fImageIncrementUni, 1, imageIncrement);

}