Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N] (Closed)

Created:
4 years ago by pilgrim_google
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Vector::append() to ::push_back() [part 5 of N] As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces append() with push_back() in Source/core/editing/. There are too many references to change them all at once, so this CL is part 5 of many. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Committed: https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b Cr-Commit-Position: refs/heads/master@{#438597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -81 lines) Patch
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 6 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 25 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
pilgrim_google
4 years ago (2016-12-14 16:36:02 UTC) #3
esprehn
lgtm
4 years ago (2016-12-14 16:54:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571953004/1
4 years ago (2016-12-14 19:20:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 19:41:00 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b Cr-Commit-Position: refs/heads/master@{#438597}
4 years ago (2016-12-14 19:45:00 UTC) #14
haraken
4 years ago (2016-12-14 23:51:07 UTC) #15
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698