third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp - Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp

Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N] (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp b/third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp

index c7fd0fdae8d920a1fdd1f13b6715cb3741993760..296a67f844906fbc5928d4db1d11a7341b380e9c 100644

--- a/third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp

@@ -65,7 +65,7 @@ void SimplifyMarkupCommand::doApply(EditingState* editingState) {

while (currentNode != rootNode) {

if (currentNode->parentNode() != rootNode &&

isRemovableBlock(currentNode))

- nodesToRemove.append(currentNode);

+ nodesToRemove.push_back(currentNode);

currentNode = currentNode->parentNode();

if (!currentNode)

@@ -90,7 +90,7 @@ void SimplifyMarkupCommand::doApply(EditingState* editingState) {

for (Node& node : NodeTraversal::inclusiveAncestorsOf(*startingNode)) {

if (node == topNodeWithStartingStyle)

break;

- nodesToRemove.append(static_cast<ContainerNode*>(&node));

+ nodesToRemove.push_back(static_cast<ContainerNode*>(&node));

}