third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N] (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index 3ec32c20dbe3f857bd7d8470f0e0515ccf86399e..c59b7d0c3f5f3f4fdab38629e7fae48b91f228fe 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -341,7 +341,7 @@ void ReplacementFragment::removeUnrenderedNodes(ContainerNode* holder) {

for (Node& node : NodeTraversal::descendantsOf(*holder)) {

if (!isNodeRendered(node) && !isTableStructureNode(&node))

- unrendered.append(&node);

+ unrendered.push_back(&node);

}

for (auto& node : unrendered)