third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp - Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N] (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp b/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

index 2ea3a63b7e6346a21291d911b26ffc82d8a3d030..87ba90484b225a313831e906072c805447cdb446 100644

--- a/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

@@ -195,7 +195,7 @@ void BreakBlockquoteCommand::doApply(EditingState* editingState) {

HeapVector<Member<Element>> ancestors;

for (Element* node = startNode->parentElement();

node && node != topBlockquote; node = node->parentElement())

- ancestors.append(node);

+ ancestors.push_back(node);

// Insert a clone of the top blockquote after the break.

Element* clonedBlockquote = topBlockquote->cloneElementWithoutChildren();