third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp - Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp

Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N] (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp b/third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp

index d396fa023484fc5ed943abab3fbf0568aa833c6f..01184001c010bc13f7d2b3190e21a7ab88e8fd58 100644

--- a/third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp

@@ -78,7 +78,7 @@ void MergeIdenticalElementsCommand::doUnapply() {

HeapVector<Member<Node>> children;

for (Node* child = m_element2->firstChild(); child && child != atChild;

child = child->nextSibling())

- children.append(child);

+ children.push_back(child);

for (auto& child : children)

m_element1->appendChild(child.release(), exceptionState);