Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings".

Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553
Committed: https://crrev.com/0280bb7ae39e544ade91fbf9dc8e13766e96b4ed
Cr-Original-Commit-Position: refs/heads/master@{#439615}
Cr-Commit-Position: refs/heads/master@{#440368}

[yzshen1, 2016-12-13 23:56:33]

Description was changed from

==========
Mojo JS bindings: switch all usage of "connection"/"router" module to
"bindings".

BUG=579646
==========

to

==========
Mojo JS bindings: switch all usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yzshen1, 2016-12-13 23:56:46]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 23:57:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-12-14 00:13:13]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 00:13:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:24:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:24:22]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yzshen1, 2016-12-15 23:13:29]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 23:14:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-12-15 23:16:07]

Description was changed from

==========
Mojo JS bindings: switch all usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yzshen1, 2016-12-15 23:16:07]

yzshen@chromium.org changed reviewers:
+ eugenebut@chromium.org, jam@chromium.org, rockot@chromium.org

[yzshen1, 2016-12-15 23:17:24]

Hi, reviewers.

Would you please take a look?

Ken: detailed review.
Eugene: ios/ changes.
John: OWNER review.

Thanks!

[commit-bot: I haz the power, 2016-12-15 23:18:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 23:18:15]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Eugene But (OOO till 7-30), 2016-12-15 23:40:58]

ios lgtm

[yzshen1, 2016-12-15 23:43:23]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 23:44:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 01:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 01:25:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-12-16 16:43:19]

So much nicer to read! LGTM

https://codereview.chromium.org/2571903003/diff/120001/chrome/test/data/webui...
File chrome/test/data/webui/plugins_browsertest.js (right):

https://codereview.chromium.org/2571903003/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/plugins_browsertest.js:112:
this.browserProxy.bindingSet(this.browserProxy, handle);
nit: addBinding :)

[yzshen1, 2016-12-16 16:55:09]

https://codereview.chromium.org/2571903003/diff/120001/chrome/test/data/webui...
File chrome/test/data/webui/plugins_browsertest.js (right):

https://codereview.chromium.org/2571903003/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/plugins_browsertest.js:112:
this.browserProxy.bindingSet(this.browserProxy, handle);
On 2016/12/16 16:43:19, Ken Rockot wrote:
> nit: addBinding :)

It scares me a little bit that this doesn't fail the test... :)

Thanks!

[yzshen1, 2016-12-16 16:55:46]

On 2016/12/16 16:55:09, yzshen1 wrote:
>
https://codereview.chromium.org/2571903003/diff/120001/chrome/test/data/webui...
> File chrome/test/data/webui/plugins_browsertest.js (right):
> 
>
https://codereview.chromium.org/2571903003/diff/120001/chrome/test/data/webui...
> chrome/test/data/webui/plugins_browsertest.js:112:
> this.browserProxy.bindingSet(this.browserProxy, handle);
> On 2016/12/16 16:43:19, Ken Rockot wrote:
> > nit: addBinding :)
> 
> It scares me a little bit that this doesn't fail the test... :)
> 
> Thanks!

Never mind, it did! :)

[yzshen1, 2016-12-16 18:16:28]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 18:17:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-12-16 18:21:22]

On 2016/12/15 23:17:24, yzshen1 wrote:
> Hi, reviewers.
> 
> Would you please take a look?
> 
> Ken: detailed review.
> Eugene: ios/ changes.
> John: OWNER review.
of which files?

you should get an owner in webkit to review those files

> 
> Thanks!

[yzshen1, 2016-12-16 18:47:12]

On 2016/12/16 18:21:22, jam wrote:
> On 2016/12/15 23:17:24, yzshen1 wrote:
> > Hi, reviewers.
> > 
> > Would you please take a look?
> > 
> > Ken: detailed review.
> > Eugene: ios/ changes.
> > John: OWNER review.
> of which files?
> 
> you should get an owner in webkit to review those files
> 
> > 
> > Thanks!

Oh, Sorry for not being clear. John, would you please do an owner review for:
  - chrome/*
  - headless/*

Thanks!

The webkit layout tests have "*" in the OWNERS files. And I think Ken is
familiar with this part of code. So I think he could cover all those files.
WDYT?

[commit-bot: I haz the power, 2016-12-16 22:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 22:08:29]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2016-12-17 00:43:13]

On 2016/12/16 18:47:12, yzshen1 wrote:
> On 2016/12/16 18:21:22, jam wrote:
> > On 2016/12/15 23:17:24, yzshen1 wrote:
> > > Hi, reviewers.
> > > 
> > > Would you please take a look?
> > > 
> > > Ken: detailed review.
> > > Eugene: ios/ changes.
> > > John: OWNER review.
> > of which files?
> > 
> > you should get an owner in webkit to review those files
> > 
> > > 
> > > Thanks!
> 
> Oh, Sorry for not being clear. John, would you please do an owner review for:
>   - chrome/*
>   - headless/*
> 
> Thanks!
> 
> The webkit layout tests have "*" in the OWNERS files. And I think Ken is
> familiar with this part of code. So I think he could cover all those files.
> WDYT?

Friendly ping, John.
Please let me know if you think I should assign those changes in chrome/* and
headless/* to other owners.
Thanks!

[jam, 2016-12-19 18:15:17]

lgtm

[yzshen1, 2016-12-19 18:15:44]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-12-19 18:15:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org, rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2571903003/#ps140001
(title: ".")

[commit-bot: I haz the power, 2016-12-19 18:16:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 20:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 20:46:45]

Failed to apply patch for
third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js:41
  error:
third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js:
patch does not apply

Patch:      
third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
Index:
third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
diff --git
a/third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
b/third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
index
b67c1d8cc370a73c027095f8261bb6b0af9dd02e..b1984890819a8c418d62ea6a0c837cbfb6d4e90f
100644
---
a/third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
+++
b/third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
@@ -41,9 +41,9 @@ function mojoMetadataToJS(mojoMetadata) {
 let mediaSessionServiceMock = loadMojoModules(
     'mediaSessionServiceMock',
    
['third_party/WebKit/public/platform/modules/mediasession/media_session.mojom',
-     'mojo/public/js/router',
+     'mojo/public/js/bindings',
     ]).then(mojo => {
-      let [mediaSessionService, router] = mojo.modules;
+      let [mediaSessionService, bindings] = mojo.modules;
 
       MediaSessionAction = mediaSessionService.MediaSessionAction;
 
@@ -51,15 +51,11 @@ let mediaSessionServiceMock = loadMojoModules(
         constructor(interfaceProvider) {
           interfaceProvider.addInterfaceOverrideForTesting(
               mediaSessionService.MediaSessionService.name,
-              handle => this.connectMediaSessionService_(handle));
+              handle => this.bindingSet_.addBinding(this, handle));
           this.interfaceProvider_ = interfaceProvider;
           this.pendingResponse_ = null;
-        }
-
-        connectMediaSessionService_(handle) {
-          this.mediaSessionServiceStub_ = new
mediaSessionService.MediaSessionService.stubClass(this);
-          this.mediaSessionServiceRouter_ = new router.Router(handle);
-         
this.mediaSessionServiceRouter_.setIncomingReceiver(this.mediaSessionServiceStub_);
+          this.bindingSet_ = new bindings.BindingSet(
+              mediaSessionService.MediaSessionService);
         }
 
         setMetadata(metadata) {

[yzshen1, 2016-12-19 21:58:02]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-12-19 21:58:02]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jam@chromium.org, eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2571903003/#ps160001
(title: "Merge remote-tracking branch 'refs/remotes/origin/master' into
c160_remove_connection_mojo")

[commit-bot: I haz the power, 2016-12-19 21:58:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 23:43:06]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1482184682104890,
"parent_rev": "5b97c8a12d59101202022c801c6effc30a0b5030", "commit_rev":
"3d7f0c9bfbc913cb949e88bdd7ad30e60369a7e2"}

[commit-bot: I haz the power, 2016-12-19 23:43:37]

Description was changed from

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2571903003
==========

[commit-bot: I haz the power, 2016-12-19 23:43:39]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-12-19 23:46:51]

Description was changed from

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2571903003
==========

to

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553
Cr-Commit-Position: refs/heads/master@{#439615}
==========

[commit-bot: I haz the power, 2016-12-19 23:46:52]

Patchset 9 (id:??) landed as
https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553
Cr-Commit-Position: refs/heads/master@{#439615}

[yzshen1, 2016-12-20 20:17:00]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2590393002/ by yzshen@chromium.org.

The reason for reverting is: Possibly caused flakiness of
WebUIMojoTest.EndToEndPing

https://bugs.chromium.org/p/chromium/issues/detail?id=676071.

[yzshen1, 2016-12-22 07:32:31]

Description was changed from

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553
Cr-Commit-Position: refs/heads/master@{#439615}
==========

to

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553
Cr-Commit-Position: refs/heads/master@{#439615}
==========

[yzshen1, 2016-12-22 07:37:52]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-12-22 07:37:52]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jam@chromium.org, eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2571903003/#ps180001
(title: "remove the changes to web_ui_mojo.js which seemed to cause flakiness.")

[commit-bot: I haz the power, 2016-12-22 07:38:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 09:22:04]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1482392272350060,
"parent_rev": "234c66946cf80f670149cfc2ff1d42c8455a71d5", "commit_rev":
"665bb72185f0210c885e845a2544779834fb62b3"}

[commit-bot: I haz the power, 2016-12-22 09:22:31]

Description was changed from

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553
Cr-Commit-Position: refs/heads/master@{#439615}
==========

to

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553
Cr-Commit-Position: refs/heads/master@{#439615}
Review-Url: https://codereview.chromium.org/2571903003
==========

[commit-bot: I haz the power, 2016-12-22 09:22:33]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-12-22 09:25:17]

Description was changed from

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553
Cr-Commit-Position: refs/heads/master@{#439615}
Review-Url: https://codereview.chromium.org/2571903003
==========

to

==========
Mojo JS bindings: switch most usage of "connection"/"router" module to
"bindings".

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553
Committed: https://crrev.com/0280bb7ae39e544ade91fbf9dc8e13766e96b4ed
Cr-Original-Commit-Position: refs/heads/master@{#439615}
Cr-Commit-Position: refs/heads/master@{#440368}
==========

[commit-bot: I haz the power, 2016-12-22 09:25:18]

Patchset 10 (id:??) landed as
https://crrev.com/0280bb7ae39e544ade91fbf9dc8e13766e96b4ed
Cr-Commit-Position: refs/heads/master@{#440368}