chrome/browser/resources/plugins.js - Issue 2571903003: Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/plugins.js

Issue 2571903003: Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". (Closed)

Patch Set: remove the changes to web_ui_mojo.js which seemed to cause flakiness. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/plugins.js

diff --git a/chrome/browser/resources/plugins.js b/chrome/browser/resources/plugins.js

index bffd6bb456c5062ac1c06882de56f851c0cdb975..f57f1332130728c4b0e4b325b782d8c1aa28d23f 100644

--- a/chrome/browser/resources/plugins.js

+++ b/chrome/browser/resources/plugins.js

@@ -228,18 +228,15 @@ var browserProxy = null;

function initializeProxies() {

return importModules([

'mojo/public/js/bindings',

- 'mojo/public/js/connection',

'chrome/browser/ui/webui/plugins/plugins.mojom',

'content/public/renderer/frame_interfaces',

]).then(function(modules) {

var bindings = modules[0];

- var connection = modules[1];

- var pluginsMojom = modules[2];

- var frameInterfaces = modules[3];

+ var pluginsMojom = modules[1];

+ var frameInterfaces = modules[2];

- browserProxy = connection.bindHandleToProxy(

- frameInterfaces.getInterface(pluginsMojom.PluginsPageHandler.name),

- pluginsMojom.PluginsPageHandler);

+ browserProxy = new pluginsMojom.PluginsPageHandlerPtr(

+ frameInterfaces.getInterface(pluginsMojom.PluginsPageHandler.name));

/** @constructor */

var PluginsPageImpl = function() {