third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js - Issue 2571903003: Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js

Issue 2571903003: Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". (Closed)

Patch Set: remove the changes to web_ui_mojo.js which seemed to cause flakiness. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/web/test/data/mojo_test.js ('k') | third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js

diff --git a/third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js b/third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js

index d1346f2c31acc831ecdff3a605153b5ec102976f..e6739ef97b3c18877490dc15b7e32b8496f48612 100644

--- a/third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js

+++ b/third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js

@@ -4,25 +4,20 @@ let mockBatteryMonitor = loadMojoModules(

'mockBatteryMonitor',

['device/battery/battery_monitor.mojom',

'device/battery/battery_status.mojom',

- 'mojo/public/js/router',

+ 'mojo/public/js/bindings',

]).then(mojo => {

- let [batteryMonitor, batteryStatus, router] = mojo.modules;

+ let [batteryMonitor, batteryStatus, bindings] = mojo.modules;

- class MockBatteryMonitor extends batteryMonitor.BatteryMonitor.stubClass {

+ class MockBatteryMonitor {

constructor(interfaceProvider) {

- super();

interfaceProvider.addInterfaceOverrideForTesting(

batteryMonitor.BatteryMonitor.name,

- handle => this.connect_(handle));

+ handle => this.bindingSet_.addBinding(this, handle));

this.interfaceProvider_ = interfaceProvider;

this.pendingRequests_ = [];

this.status_ = null;

- }

- connect_(handle) {

- this.router_ = new router.Router(handle);

- this.router_.setIncomingReceiver(this);

+ this.bindingSet_ = new bindings.BindingSet(batteryMonitor.BatteryMonitor);

}

queryNextStatus() {