headless/lib/embedder_mojo_browsertest.cc - Issue 2571903003: Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/embedder_mojo_browsertest.cc

Issue 2571903003: Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". (Closed)

Patch Set: remove the changes to web_ui_mojo.js which seemed to cause flakiness. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/embedder_mojo_browsertest.cc

diff --git a/headless/lib/embedder_mojo_browsertest.cc b/headless/lib/embedder_mojo_browsertest.cc

index 3fb4ed1a5f5e6d1ca2b642c714c6f5290774cbce..0ae117b33dca0eeed79908682eb1b5a84ffdeefa 100644

--- a/headless/lib/embedder_mojo_browsertest.cc

+++ b/headless/lib/embedder_mojo_browsertest.cc

@@ -152,16 +152,12 @@ class MojoBindingsTest : public EmbedderMojoTest {

"// fires after the requested modules have been loaded. \n"

"define([ \n"

" 'headless/lib/embedder_test.mojom', \n"

- " 'mojo/public/js/core', \n"

- " 'mojo/public/js/router', \n"

" 'content/public/renderer/frame_interfaces', \n"

- " ], function(embedderMojom, mojoCore, routerModule, \n"

- " frameInterfaces) { \n"

+ " ], function(embedderMojom, frameInterfaces) { \n"

" var testEmbedderService = \n"

- " new embedderMojom.TestEmbedderService.proxyClass( \n"

- " new routerModule.Router( \n"

- " frameInterfaces.getInterface( \n"

- " embedderMojom.TestEmbedderService.name))); \n"

+ " new embedderMojom.TestEmbedderServicePtr( \n"

+ " frameInterfaces.getInterface( \n"

+ " embedderMojom.TestEmbedderService.name)); \n"

" \n"

" // Send a message to the embedder! \n"

" testEmbedderService.returnTestResult('hello world'); \n"

« no previous file with comments | « extensions/test/data/api_test_base_unittest.js ('k') | headless/test/data/page_one.html » ('j') | no next file with comments »