chrome/browser/resources/omnibox/omnibox.js - Issue 2571903003: Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/omnibox/omnibox.js

Issue 2571903003: Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". (Closed)

Patch Set: remove the changes to web_ui_mojo.js which seemed to cause flakiness. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/omnibox/omnibox.js

diff --git a/chrome/browser/resources/omnibox/omnibox.js b/chrome/browser/resources/omnibox/omnibox.js

index 11c4a9939d948dcfa02e842863197c216b318f50..2570deb46d9d758f4244614d8b4da7fe751ee3bf 100644

--- a/chrome/browser/resources/omnibox/omnibox.js

+++ b/chrome/browser/resources/omnibox/omnibox.js

@@ -416,18 +416,15 @@

function initializeProxies() {

return importModules([

'mojo/public/js/bindings',

- 'mojo/public/js/connection',

'chrome/browser/ui/webui/omnibox/omnibox.mojom',

'content/public/renderer/frame_interfaces',

]).then(function(modules) {

var bindings = modules[0];

- var connection = modules[1];

- var mojom = modules[2];

- var frameInterfaces = modules[3];

+ var mojom = modules[1];

+ var frameInterfaces = modules[2];

- browserProxy = connection.bindHandleToProxy(

- frameInterfaces.getInterface(mojom.OmniboxPageHandler.name),

- mojom.OmniboxPageHandler);

+ browserProxy = new mojom.OmniboxPageHandlerPtr(

+ frameInterfaces.getInterface(mojom.OmniboxPageHandler.name));

/** @constructor */

var OmniboxPageImpl = function() {