[Payment Request] Mark some tests as flaky, and attempt fixes

[Payment Request] Mark some tests as flaky, and attempt fixes

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just
  speculative at this point; a more comprehensive fix is in order.

BUG=673371
TEST=PaymentRequest* (java)

Committed: https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264
Cr-Commit-Position: refs/heads/master@{#438182}

[Mathieu, 2016-12-12 15:51:38]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 15:51:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2016-12-12 15:59:31]

Description was changed from

==========
[Payment Request] Fix flaky test behavior.

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).
This change modifies the tests to make sure they reflect the behavior.

BUG=673133
TEST=PaymentRequest* (java)
==========

to

==========
[Payment Request] Fix flaky test behavior.

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).
This change modifies the tests to make sure they reflect the behavior.

BUG=673133, 673136
TEST=PaymentRequest* (java)
==========

[Mathieu, 2016-12-12 16:00:25]

Description was changed from

==========
[Payment Request] Fix flaky test behavior.

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).
This change modifies the tests to make sure they reflect the behavior.

BUG=673133, 673136
TEST=PaymentRequest* (java)
==========

to

==========
[Payment Request] Fix flaky test behavior.

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).
This change modifies the tests to make sure they reflect the behavior.

BUG=673133, 673136, 673299
TEST=PaymentRequest* (java)
==========

[Mathieu, 2016-12-12 20:55:33]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 20:56:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2016-12-12 22:30:35]

Description was changed from

==========
[Payment Request] Fix flaky test behavior.

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).
This change modifies the tests to make sure they reflect the behavior.

BUG=673133, 673136, 673299
TEST=PaymentRequest* (java)
==========

to

==========
[Payment Request] Fix flaky test behavior.

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).
This change modifies the tests to make sure they reflect the behavior.

BUG=673371
TEST=PaymentRequest* (java)
==========

[Mathieu, 2016-12-13 02:08:54]

Description was changed from

==========
[Payment Request] Fix flaky test behavior.

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).
This change modifies the tests to make sure they reflect the behavior.

BUG=673371
TEST=PaymentRequest* (java)
==========

to

==========
[Payment Request] Fix flaky test behavior.

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just speculative
at this point; a more comprehensive fix is in order. 

BUG=673371
TEST=PaymentRequest* (java)
==========

[Mathieu, 2016-12-13 02:09:11]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[Mathieu, 2016-12-13 02:09:31]

Description was changed from

==========
[Payment Request] Fix flaky test behavior.

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just speculative
at this point; a more comprehensive fix is in order. 

BUG=673371
TEST=PaymentRequest* (java)
==========

to

==========
[Payment Request] Mark some tests as flaky, and attempt fixes

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just speculative
at this point; a more comprehensive fix is in order. 

BUG=673371
TEST=PaymentRequest* (java)
==========

[Mathieu, 2016-12-13 02:09:31]

mathp@chromium.org changed reviewers:
+ rouslan@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:09:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:03:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 03:03:37]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2016-12-13 03:12:45]

Ptal

[please use gerrit instead, 2016-12-13 14:42:07]

Description was changed from

==========
[Payment Request] Mark some tests as flaky, and attempt fixes

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just speculative
at this point; a more comprehensive fix is in order. 

BUG=673371
TEST=PaymentRequest* (java)
==========

to

==========
[Payment Request] Mark some tests as flaky, and attempt fixes

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just
  speculative at this point; a more comprehensive fix is in order. 

BUG=673371
TEST=PaymentRequest* (java)
==========

[please use gerrit instead, 2016-12-13 14:44:45]

LGTM % question

Is there a particular reason you removed @MediumTest in those places where you
marked the tests flaky?

[Mathieu, 2016-12-13 15:23:10]

On 2016/12/13 14:44:45, rouslan wrote:
> LGTM % question
> 
> Is there a particular reason you removed @MediumTest in those places where you
> marked the tests flaky?

No valid reason at all - I guess I got confused after seeing a @DisabledTest
that removed it. Added @MediumTest back in.

[Mathieu, 2016-12-13 15:23:16]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-12-13 15:23:16]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2571493002/#ps140001
(title: "MediumTest annotations")

[commit-bot: I haz the power, 2016-12-13 15:23:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 16:04:14]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1481642596471460,
"parent_rev": "d26ec5247bb9d70316137f8dbc4f1ff25d8aac80", "commit_rev":
"7929d47579b0a7de6f53e920e0ddcceee8fbb717"}

[commit-bot: I haz the power, 2016-12-13 16:04:39]

Description was changed from

==========
[Payment Request] Mark some tests as flaky, and attempt fixes

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just
  speculative at this point; a more comprehensive fix is in order. 

BUG=673371
TEST=PaymentRequest* (java)
==========

to

==========
[Payment Request] Mark some tests as flaky, and attempt fixes

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just
  speculative at this point; a more comprehensive fix is in order. 

BUG=673371
TEST=PaymentRequest* (java)

Review-Url: https://codereview.chromium.org/2571493002
==========

[commit-bot: I haz the power, 2016-12-13 16:04:42]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-12-13 16:09:25]

Description was changed from

==========
[Payment Request] Mark some tests as flaky, and attempt fixes

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just
  speculative at this point; a more comprehensive fix is in order. 

BUG=673371
TEST=PaymentRequest* (java)

Review-Url: https://codereview.chromium.org/2571493002
==========

to

==========
[Payment Request] Mark some tests as flaky, and attempt fixes

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just
  speculative at this point; a more comprehensive fix is in order.

BUG=673371
TEST=PaymentRequest* (java)

Committed: https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264
Cr-Commit-Position: refs/heads/master@{#438182}
==========

[commit-bot: I haz the power, 2016-12-13 16:09:26]

Patchset 8 (id:??) landed as
https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264
Cr-Commit-Position: refs/heads/master@{#438182}