Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java

Issue 2571493002: [Payment Request] Mark some tests as flaky, and attempt fixes (Closed)
Patch Set: MediumTest annotations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
index fab7a5848d6d1bcd19d6aab9e94d9a499f541ac9..2cd5f5d8f5d0ff8b30edfb62294ce2f894399570 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
@@ -9,6 +9,7 @@ import android.test.suitebuilder.annotation.MediumTest;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.FlakyTest;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.autofill.AutofillTestHelper;
import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;
@@ -52,6 +53,7 @@ public class PaymentRequestPhoneTest extends PaymentRequestTestBase {
/** Attempt to add an invalid phone number and cancel the transaction. */
@MediumTest
+ @FlakyTest(message = "crbug.com/673371")
@Feature({"Payments"})
public void testAddInvalidPhoneAndCancel()
throws InterruptedException, ExecutionException, TimeoutException {
@@ -60,7 +62,7 @@ public class PaymentRequestPhoneTest extends PaymentRequestTestBase {
clickInContactInfoAndWait(R.id.payments_add_option_button, mReadyToEdit);
setTextInEditorAndWait(new String[] {"+++"}, mEditorTextUpdate);
clickInEditorAndWait(R.id.payments_edit_done_button, mEditorValidationError);
- clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}

Powered by Google App Engine
This is Rietveld 408576698