Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java

Issue 2571493002: [Payment Request] Mark some tests as flaky, and attempt fixes (Closed)
Patch Set: MediumTest annotations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
index bf21cf14dd7f0596c20ac8c0010f33f9c2d6ec62..0dada2a175a34b711b578155229441fa07a88151 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
@@ -10,6 +10,7 @@ import android.test.suitebuilder.annotation.MediumTest;
import org.chromium.base.ThreadUtils;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.FlakyTest;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.autofill.AutofillTestHelper;
import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;
@@ -55,6 +56,7 @@ public class PaymentRequestFreeShippingTest extends PaymentRequestTestBase {
/** Attempt to add an invalid address and cancel the transaction. */
@MediumTest
+ @FlakyTest(message = "crbug.com/673371")
@Feature({"Payments"})
public void testAddInvalidAddressAndCancel()
throws InterruptedException, ExecutionException, TimeoutException {
@@ -62,7 +64,7 @@ public class PaymentRequestFreeShippingTest extends PaymentRequestTestBase {
clickInShippingSummaryAndWait(R.id.payments_section, mReadyForInput);
clickInShippingAddressAndWait(R.id.payments_add_option_button, mReadyToEdit);
clickInEditorAndWait(R.id.payments_edit_done_button, mEditorValidationError);
- clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}
@@ -124,7 +126,7 @@ public class PaymentRequestFreeShippingTest extends PaymentRequestTestBase {
});
mReadyToEdit.waitForCallback(callCount);
- clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}
@@ -154,6 +156,7 @@ public class PaymentRequestFreeShippingTest extends PaymentRequestTestBase {
/** Quickly pressing on "add address" and then "cancel" should not crash. */
@MediumTest
+ @FlakyTest(message = "crbug.com/673371")
@Feature({"Payments"})
public void testQuickAddAddressAndCancelShouldNotCrash()
throws InterruptedException, ExecutionException, TimeoutException {
@@ -172,7 +175,7 @@ public class PaymentRequestFreeShippingTest extends PaymentRequestTestBase {
});
mReadyToEdit.waitForCallback(callCount);
- clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}

Powered by Google App Engine
This is Rietveld 408576698