Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2945)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java

Issue 2571493002: [Payment Request] Mark some tests as flaky, and attempt fixes (Closed)
Patch Set: MediumTest annotations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
index 4819abb1a4339b062c4549b76f08d150e9188922..606c38246cc55778a5b3555005d252879b4c57e4 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
@@ -9,8 +9,8 @@ import android.test.suitebuilder.annotation.MediumTest;
import org.chromium.base.ThreadUtils;
import org.chromium.base.metrics.RecordHistogram;
-import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.FlakyTest;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.autofill.AutofillTestHelper;
import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;
@@ -53,9 +53,9 @@ public class PaymentRequestContactDetailsTest extends PaymentRequestTestBase {
}
/** Attempt to add invalid contact information and cancel the transaction. */
- // @MediumTest
- // @Feature({"Payments"})
- @DisabledTest
+ @MediumTest
+ @FlakyTest(message = "crbug.com/673371")
+ @Feature({"Payments"})
public void testAddInvalidContactAndCancel()
throws InterruptedException, ExecutionException, TimeoutException {
triggerUIAndWait(mReadyToPay);
@@ -63,7 +63,7 @@ public class PaymentRequestContactDetailsTest extends PaymentRequestTestBase {
clickInContactInfoAndWait(R.id.payments_add_option_button, mReadyToEdit);
setTextInEditorAndWait(new String[] {"", "+++", "jane.jones"}, mEditorTextUpdate);
clickInEditorAndWait(R.id.payments_edit_done_button, mEditorValidationError);
- clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}
@@ -105,7 +105,7 @@ public class PaymentRequestContactDetailsTest extends PaymentRequestTestBase {
});
mReadyToEdit.waitForCallback(callCount);
- clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}
@@ -144,7 +144,7 @@ public class PaymentRequestContactDetailsTest extends PaymentRequestTestBase {
clickInContactInfoAndWait(R.id.payments_open_editor_pencil_button, mReadyToEdit);
// Cancel the editor.
- clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
// Expect the row to still be selected in the Contact Details section.
expectContactDetailsRowIsSelected(0);
@@ -161,7 +161,7 @@ public class PaymentRequestContactDetailsTest extends PaymentRequestTestBase {
clickInContactInfoAndWait(R.id.payments_add_option_button, mReadyToEdit);
// Cancel the editor.
- clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
// Expect the existing row to still be selected in the Contact Details section.
expectContactDetailsRowIsSelected(0);
@@ -187,7 +187,7 @@ public class PaymentRequestContactDetailsTest extends PaymentRequestTestBase {
});
mReadyToEdit.waitForCallback(callCount);
- clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698