Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java

Issue 2571493002: [Payment Request] Mark some tests as flaky, and attempt fixes (Closed)
Patch Set: MediumTest annotations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
index ab8fc4b26c9c90727b5f0d9c0b29c3fb3a68185a..860faa2b27a2c636c8eda3fc257151f24ab353fd 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
@@ -98,17 +98,15 @@ public class PaymentRequestNoShippingTest extends PaymentRequestTestBase {
"123"});
}
- /**
- * Attempt to add an invalid credit card number and cancel payment.
- * @MediumTest
- */
- @FlakyTest(message = "crbug.com/626289")
+ /** Attempt to add an invalid credit card number and cancel payment. */
+ @MediumTest
+ @FlakyTest(message = "crbug.com/673371")
@Feature({"Payments"})
public void testAddInvalidCardNumberAndCancel()
throws InterruptedException, ExecutionException, TimeoutException {
fillNewCardForm("123", "Bob", DECEMBER, NEXT_YEAR, FIRST_BILLING_ADDRESS);
clickInCardEditorAndWait(R.id.payments_edit_done_button, mEditorValidationError);
- clickInCardEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInCardEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}
@@ -123,17 +121,15 @@ public class PaymentRequestNoShippingTest extends PaymentRequestTestBase {
new int[] {month, year, billingAddress}, mBillingAddressChangeProcessed);
}
- /**
- * Attempt to add a credit card with an empty name on card and cancel payment.
- * @MediumTest
- */
- @FlakyTest(message = "crbug.com/626289")
+ /** Attempt to add a credit card with an empty name on card and cancel payment. */
+ @MediumTest
+ @FlakyTest(message = "crbug.com/673371")
@Feature({"Payments"})
public void testAddEmptyNameOnCardAndCancel()
throws InterruptedException, ExecutionException, TimeoutException {
fillNewCardForm("5454-5454-5454-5454", "", DECEMBER, NEXT_YEAR, FIRST_BILLING_ADDRESS);
clickInCardEditorAndWait(R.id.payments_edit_done_button, mEditorValidationError);
- clickInCardEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInCardEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}
@@ -216,7 +212,7 @@ public class PaymentRequestNoShippingTest extends PaymentRequestTestBase {
});
mReadyToEdit.waitForCallback(callCount);
- clickInCardEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInCardEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}
@@ -264,7 +260,7 @@ public class PaymentRequestNoShippingTest extends PaymentRequestTestBase {
});
mReadyToEdit.waitForCallback(callCount);
- clickInCardEditorAndWait(R.id.payments_edit_cancel_button, mReadyForInput);
+ clickInCardEditorAndWait(R.id.payments_edit_cancel_button, mReadyToPay);
clickAndWait(R.id.close_button, mDismissed);
expectResultContains(new String[] {"Request cancelled"});
}

Powered by Google App Engine
This is Rietveld 408576698