Suppress deprecation warnings in non-clang builds too

Suppress deprecation warnings in non-clang builds too

https://codereview.chromium.org/2504463002 added suppresion of
deprecation warnings in an "if clang" block, but gcc also warns about
these, as can be seen on Chrome-Android waterfall for example. Fix
by moving the supression to an if linux||android block.

BUG=21515
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/icu/+/9cd2828740572ba6f694b9365236a8356fd06147

[tsniatowski, 2016-12-12 10:30:40]

Description was changed from

==========
Suppress deprecation warnings in non-clang builds too

https://codereview.chromium.org/250446300 added suppresion of
deprecation warnings in an "if clang" block, but gcc also warns about
these, as can be seen on Chrome-Android waterfall for example. Fix
by moving the supression to an if linux||android block.

BUG=21515
R=thakis@chromium.org
==========

to

==========
Suppress deprecation warnings in non-clang builds too

https://codereview.chromium.org/250446300 added suppresion of
deprecation warnings in an "if clang" block, but gcc also warns about
these, as can be seen on Chrome-Android waterfall for example. Fix
by moving the supression to an if linux||android block.

BUG=21515
R=thakis@chromium.org
==========

[Nico, 2016-12-12 15:00:27]

https://codereview.chromium.org/250446300 says "no issue exists with that id"

[Nico, 2016-12-12 15:00:53]

https://codereview.chromium.org/2571433002/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2571433002/diff/1/BUILD.gn#oldcode87
BUILD.gn:87: "-Wno-deprecated-declarations",
this breaks win/clang builds

[tsniatowski, 2016-12-12 15:04:11]

On 2016/12/12 15:00:27, Nico wrote:
> https://codereview.chromium.org/250446300 says "no issue exists with that id"

ugh, copy paste error. should be https://codereview.chromium.org/2504463002

[tsniatowski, 2016-12-12 15:04:21]

https://codereview.chromium.org/2571433002/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2571433002/diff/1/BUILD.gn#oldcode87
BUILD.gn:87: "-Wno-deprecated-declarations",
On 2016/12/12 15:00:53, Nico wrote:
> this breaks win/clang builds

interesting. this exists already at around line 511, in a target that uses this
config already. squash all into one shared "if clang or android/linux" section
in the config?

[Nico, 2016-12-12 15:09:05]

https://codereview.chromium.org/2571433002/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2571433002/diff/1/BUILD.gn#oldcode87
BUILD.gn:87: "-Wno-deprecated-declarations",
On 2016/12/12 15:04:21, tsniatowski wrote:
> On 2016/12/12 15:00:53, Nico wrote:
> > this breaks win/clang builds
> 
> interesting. this exists already at around line 511, in a target that uses
this
> config already. squash all into one shared "if clang or android/linux" section
> in the config?

Either that, or just keep these two lines here and add the two you're adding.
(See lhs of https://codereview.chromium.org/2492553006/diff/40001/BUILD.gn)

[Nico, 2016-12-12 15:10:13]

https://codereview.chromium.org/2571433002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2571433002/diff/20001/BUILD.gn#newcode542
BUILD.gn:542: public_configs = [ ":icu_config" ]
Uuuh this isn't good, since this is a public config you're now disabling
deprecation warnings for every target (transitively depending on icu), i.e.
roughly all of them.

[tsniatowski, 2016-12-12 15:14:50]

https://codereview.chromium.org/2571433002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2571433002/diff/20001/BUILD.gn#newcode542
BUILD.gn:542: public_configs = [ ":icu_config" ]
On 2016/12/12 15:10:13, Nico wrote:
> Uuuh this isn't good, since this is a public config you're now disabling
> deprecation warnings for every target (transitively depending on icu), i.e.
> roughly all of them.

icu_code is a nonpublic config here (and everywhere else in this file),
icu_config is public but I'm not touching that.

[Nico, 2016-12-12 15:29:15]

lgtm

[tsniatowski, 2016-12-12 15:30:19]

On 2016/12/12 15:29:15, Nico wrote:
> lgtm

Thanks. Can you land this? (I don't have commiter access)

[Nico, 2016-12-12 15:30:38]

Just hit the "commit" checkbox.

On Mon, Dec 12, 2016 at 10:30 AM, <tsniatowski@opera.com> wrote:

> On 2016/12/12 15:29:15, Nico wrote:
> > lgtm
>
> Thanks. Can you land this? (I don't have commiter access)
>
> https://codereview.chromium.org/2571433002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tsniatowski, 2016-12-12 15:32:56]

On 2016/12/12 15:30:38, Nico wrote:
> Just hit the "commit" checkbox.

I can see no such checkbox, only "Project "icu" does not have a commit queue."
in the usual place.

[Nico, 2016-12-12 15:33:20]

Oh right, icu repo, sorry. I'll try to remember to land it some time today.

[tsniatowski, 2016-12-12 15:33:26]

Description was changed from

==========
Suppress deprecation warnings in non-clang builds too

https://codereview.chromium.org/250446300 added suppresion of
deprecation warnings in an "if clang" block, but gcc also warns about
these, as can be seen on Chrome-Android waterfall for example. Fix
by moving the supression to an if linux||android block.

BUG=21515
R=thakis@chromium.org
==========

to

==========
Suppress deprecation warnings in non-clang builds too

https://codereview.chromium.org/2504463002 added suppresion of
deprecation warnings in an "if clang" block, but gcc also warns about
these, as can be seen on Chrome-Android waterfall for example. Fix
by moving the supression to an if linux||android block.

BUG=21515
R=thakis@chromium.org
==========

[tsniatowski, 2016-12-12 15:34:23]

On 2016/12/12 15:33:20, Nico wrote:
> Oh right, icu repo, sorry. I'll try to remember to land it some time today.

thanks!

(just remembered to fix the commit message, btw)

[Nico, 2016-12-12 20:29:55]

Description was changed from

==========
Suppress deprecation warnings in non-clang builds too

https://codereview.chromium.org/2504463002 added suppresion of
deprecation warnings in an "if clang" block, but gcc also warns about
these, as can be seen on Chrome-Android waterfall for example. Fix
by moving the supression to an if linux||android block.

BUG=21515
R=thakis@chromium.org
==========

to

==========
Suppress deprecation warnings in non-clang builds too

https://codereview.chromium.org/2504463002 added suppresion of
deprecation warnings in an "if clang" block, but gcc also warns about
these, as can be seen on Chrome-Android waterfall for example. Fix
by moving the supression to an if linux||android block.

BUG=21515
R=thakis@chromium.org

Committed:
https://chromium.googlesource.com/chromium/deps/icu/+/9cd2828740572ba6f694b93...
==========

[Nico, 2016-12-12 20:29:56]

Committed patchset #2 (id:20001) manually as
9cd2828740572ba6f694b9365236a8356fd06147 (presubmit successful).

[Nico, 2016-12-12 20:30:49]

Landed. You need to roll icu in DEPS for chromium to pick this up.