Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2504463002: Return to suppressing deprecation warnings (Closed)

Created:
4 years, 1 month ago by brucedawson
Modified:
4 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
icu
Visibility:
Public.

Description

Return to suppressing deprecation warnings The previous change re-enabled warnings too aggressively. While the icu target built correctly the icu nacl targets (such as irt_x64/obj/third_party/icu/icuuc/uidna.o on Windows and newlib_pnacl/obj/third_party/icu/icuuc/uidna.o on other platforms) failed to compile due to deprecation warnings. This change adds back suppression of that one warning. BUG=21515 R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/4d1363242056c308ab12f19c5c0f28aed8acc858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
brucedawson
This time it almost certainly works!
4 years, 1 month ago (2016-11-14 23:02:52 UTC) #3
Nico
lgtm!
4 years, 1 month ago (2016-11-14 23:03:20 UTC) #4
brucedawson
4 years, 1 month ago (2016-11-15 15:13:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d1363242056c308ab12f19c5c0f28aed8acc858 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698