Suppress deprecation warnings in non-clang builds too

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//third_party/icu/config.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
@@ skipping 61 matching lines @@
     cflags += [
       "/wd4005",  # Macro redefinition.
       "/wd4068",  # Unknown pragmas.
       "/wd4267",  # Conversion from size_t on 64-bits.
       # http://bugs.icu-project.org/trac/ticket/12821
       "/wd4333",  # Right shift by too large amount.
     ]
   } else if (is_linux || is_android) {
     cflags += [
       "-Wno-unused-function",
+      # ICU uses its own deprecated functions.
+      "-Wno-deprecated-declarations",
     ]
   }
   if (is_clang) {
     cflags += [
-      # ICU uses its own deprecated functions.
-      "-Wno-deprecated-declarations",

[Nico, 2016/12/12 15:00:53]

this breaks win/clang builds

[tsniatowski, 2016/12/12 15:04:21]

interesting. this exists already at around line 511, in a target that uses this
config already. squash all into one shared "if clang or android/linux" section
in the config?

[Nico, 2016/12/12 15:09:05]

Either that, or just keep these two lines here and add the two you're adding.
(See lhs of https://codereview.chromium.org/2492553006/diff/40001/BUILD.gn)

       # ICU has some code with the pattern:
       #   if (found = uprv_getWindowsTimeZoneInfo(...))
       "-Wno-parentheses",
       # ucnv2022.cpp contains three functions that are only used when
       # certain preprocessor defines are set.
       # unistr.cpp also has an unused function for non-component builds.
       "-Wno-unused-function",
     ]
   }
 }
@@ skipping 927 matching lines @@
       }
     }
 
     source_set("icudata") {
       sources = [ "$data_assembly" ]
       defines = [ "U_HIDE_DATA_SYMBOL" ]
       deps = [ ":make_data_assembly", ]
     }
   }
 }