Suppress deprecation warnings in non-clang builds too

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//third_party/icu/config.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
@@ skipping 65 matching lines @@
       # http://bugs.icu-project.org/trac/ticket/12821
       "/wd4333",  # Right shift by too large amount.
     ]
   } else if (is_linux || is_android) {
     cflags += [
       "-Wno-unused-function",
     ]
   }
   if (is_clang) {
     cflags += [
-      # ICU uses its own deprecated functions.
-      "-Wno-deprecated-declarations",
       # ICU has some code with the pattern:
       #   if (found = uprv_getWindowsTimeZoneInfo(...))
       "-Wno-parentheses",
       # ucnv2022.cpp contains three functions that are only used when
       # certain preprocessor defines are set.
       # unistr.cpp also has an unused function for non-component builds.
       "-Wno-unused-function",
     ]
   }
+  if (is_clang || is_linux || is_android) {
+    cflags += [
+      # ICU uses its own deprecated functions.
+      "-Wno-deprecated-declarations",
+    ]
+  }
 }
 
 component("icui18n") {
   # find  source/i18n -maxdepth 1  ! -type d  | egrep  '\.(c|cpp|h)$' |\
   # sort | sed 's/^\(.*\)$/    "\1",/'
   sources = [
     "source/i18n/affixpatternparser.cpp",
     "source/i18n/affixpatternparser.h",
     "source/i18n/alphaindex.cpp",
     "source/i18n/anytrans.cpp",
@@ skipping 421 matching lines @@
   configs -= [
     "//build/config/compiler:no_rtti",  # ICU uses RTTI.
     "//build/config/compiler:chromium_code",
   ]
   configs += [
     "//build/config/compiler:rtti",
     "//build/config/compiler:no_chromium_code",
   ]
 
   configs += [ ":icu_code" ]
   public_configs = [ ":icu_config" ]

[Nico, 2016/12/12 15:10:13]

Uuuh this isn't good, since this is a public config you're now disabling
deprecation warnings for every target (transitively depending on icu), i.e.
roughly all of them.

[tsniatowski, 2016/12/12 15:14:50]

icu_code is a nonpublic config here (and everywhere else in this file),
icu_config is public but I'm not touching that.

-
-  cflags = []
-  if (is_android || is_linux) {
-    cflags += [
-      # ICU uses its own deprecated functions.
-      "-Wno-deprecated-declarations",
-    ]
-  }
 }
 
 component("icuuc") {
   # find  source/common -maxdepth 1  ! -type d  | egrep  '\.(c|cpp|h)$' |\
   # sort | sed 's/^\(.*\)$/    "\1",/'
   sources = [
     "source/common/appendable.cpp",
     "source/common/bmpset.cpp",
     "source/common/bmpset.h",
     "source/common/brkeng.cpp",
@@ skipping 468 matching lines @@
       }
     }
 
     source_set("icudata") {
       sources = [ "$data_assembly" ]
       defines = [ "U_HIDE_DATA_SYMBOL" ]
       deps = [ ":make_data_assembly", ]
     }
   }
 }