Re-enable as many clang warning as possible

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//third_party/icu/config.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
@@ skipping 55 matching lines @@
     # Will cut down the code size.
     "U_CHARSET_IS_UTF8=1",
   ]
 
   if (is_win) {
     # Disable some compiler warnings.
     cflags += [
       "/wd4005",  # Macro redefinition.
       "/wd4068",  # Unknown pragmas.
       "/wd4267",  # Conversion from size_t on 64-bits.
-      "/wd4996",  # Deprecated functions.
-      # http://bugs.icu-project.org/trac/ticket/12821

[jungshik at Google, 2016/11/15 18:06:36]

Did you mean to remove this comment? It's for wd4333 we still have to keep. 

[brucedawson, 2016/11/15 19:53:48]

Good catch. I accidentally associated the comment with the previous line instead
of with the subsequent line. I'll put it back.

       "/wd4333",  # Right shift by too large amount.
     ]
   } else if (is_linux || is_android) {
     cflags += [
-      # Since ICU wants to internally use its own deprecated APIs, don't
-      # complain about it.
-      "-Wno-deprecated-declarations",
       "-Wno-unused-function",
     ]
   }
   if (is_clang) {
     cflags += [
-      # ICU uses its own deprecated functions.
-      "-Wno-deprecated-declarations",
-      # ICU prefers `a && b || c` over `(a && b) || c`.
-      "-Wno-logical-op-parentheses",
-      # ICU has some `unsigned < 0` checks.
-      "-Wno-tautological-compare",
-      # uresdata.c has switch(RES_GET_TYPE(x)) code. The
-      # RES_GET_TYPE macro returns an UResType enum, but some switch
-      # statement contains case values that aren't part of that
-      # enum (e.g. URES_TABLE32 which is in UResInternalType). This
-      # is on purpose.
-      "-Wno-switch",
       # ICU has some code with the pattern:
       #   if (found = uprv_getWindowsTimeZoneInfo(...))
       "-Wno-parentheses",
       # ucnv2022.cpp contains three functions that are only used when
       # certain preprocessor defines are set.
       # unistr.cpp also has an unused function for non-component builds.
       "-Wno-unused-function",
     ]
-    if (is_win) {
-      cflags += [
-        # See http://bugs.icu-project.org/trac/ticket/11122
-        "-Wno-inline-new-delete",
-        "-Wno-implicit-exception-spec-mismatch",
-        # See http://www.icu-project.org/trac/ticket/11759.
-        "-Wno-unused-const-variable",
-      ]
-    }
   }
 }
 
 component("icui18n") {
   # find  source/i18n -maxdepth 1  ! -type d  | egrep  '\.(c|cpp|h)$' |\
   # sort | sed 's/^\(.*\)$/    "\1",/'
   sources = [
     "source/i18n/affixpatternparser.cpp",
     "source/i18n/affixpatternparser.h",
     "source/i18n/alphaindex.cpp",
@@ skipping 918 matching lines @@
       }
     }
 
     source_set("icudata") {
       sources = [ "$data_assembly" ]
       defines = [ "U_HIDE_DATA_SYMBOL" ]
       deps = [ ":make_data_assembly", ]
     }
   }
 }