Suppress deprecation warnings in non-clang builds too

BUILD.gn

Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index ac6b2bb01f73a9d582e1900ef7255d318e001230..4e9364b7eabd9bf024632f7df41ae66a436fc632 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -83,8 +83,6 @@ config("icu_code") {
   }
   if (is_clang) {
     cflags += [
-      # ICU uses its own deprecated functions.
-      "-Wno-deprecated-declarations",
       # ICU has some code with the pattern:
       #   if (found = uprv_getWindowsTimeZoneInfo(...))
       "-Wno-parentheses",
@@ -94,6 +92,12 @@ config("icu_code") {
       "-Wno-unused-function",
     ]
   }
+  if (is_clang || is_linux || is_android) {
+    cflags += [
+      # ICU uses its own deprecated functions.
+      "-Wno-deprecated-declarations",
+    ]
+  }
 }
 
 component("icui18n") {
@@ -536,14 +540,6 @@ component("icui18n") {
 
   configs += [ ":icu_code" ]
   public_configs = [ ":icu_config" ]

[Nico, 2016/12/12 15:10:13]

Uuuh this isn't good, since this is a public config you're now disabling
deprecation warnings for every target (transitively depending on icu), i.e.
roughly all of them.

[tsniatowski, 2016/12/12 15:14:50]

icu_code is a nonpublic config here (and everywhere else in this file),
icu_config is public but I'm not touching that.

-
-  cflags = []
-  if (is_android || is_linux) {
-    cflags += [
-      # ICU uses its own deprecated functions.
-      "-Wno-deprecated-declarations",
-    ]
-  }
 }
 
 component("icuuc") {