Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2570483002: Revert of Simple BlinkGC heap compaction. (Closed)

Created:
4 years ago by yhirano
Modified:
4 years ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Simple BlinkGC heap compaction. (patchset #22 id:420001 of https://codereview.chromium.org/2531973002/ ) Reason for revert: Speculative revert for a layout test breakage. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/13912 Original issue's description: > Simple BlinkGC heap compaction. > > This implements heap compaction for the Blink GC infrastructure > (Oilpan), compacting the arenas of the BlinkGC heap which are most > susceptible to becoming fragmented during actual use. > > Fragmentation is a real problem and a growing one while browsing anything > but static pages: the amount of unused, but allocated, memory is > fluctuating higher over time. > > To avoid leaving increasing amounts of unused holes in our heaps, > heap compaction will periodically squeeze out the unused portions, > packing together the live objects. The heap pages that are then > left as unused, are subsequently released and returned to the OS. > > Due to a fortunate property of Blink heap collection types, providing > such compaction is within relatively easy reach. Experiments show that > the arenas which hold such collection objects ("backing stores") are > the ones that develop fragmentation the most & persistently. While not > a complete heap compactor of all Blink GC arenas, it addresses the > fragmentation problem where it is most pressing. More can be done, later. > > Explainer / design document: > > https://docs.google.com/document/d/1k-vivOinomDXnScw8Ew5zpsYCXiYqj76OCOYZSvHkaU > > R=haraken > BUG=672030 > > Review-Url: https://codereview.chromium.org/2531973002 TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672030 Committed: https://crrev.com/88209344ccad5aa05ce1c70a77c8942bc7b20a75 Cr-Commit-Position: refs/heads/master@{#437834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2010 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGC.h View 3 chunks +1 line, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 4 chunks +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 2 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/Source/platform/heap/HeapCompact.h View 1 chunk +0 lines, -207 lines 0 comments Download
D third_party/WebKit/Source/platform/heap/HeapCompact.cpp View 1 chunk +0 lines, -479 lines 0 comments Download
D third_party/WebKit/Source/platform/heap/HeapCompactTest.cpp View 1 chunk +0 lines, -461 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 3 chunks +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 6 chunks +1 line, -270 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 7 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitor.h View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/Source/platform/heap/SparseHeapBitmap.h View 1 chunk +0 lines, -136 lines 0 comments Download
D third_party/WebKit/Source/platform/heap/SparseHeapBitmap.cpp View 1 chunk +0 lines, -111 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 3 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 10 chunks +5 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 5 chunks +2 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/Deque.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 2 chunks +0 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yhirano
Created Revert of Simple BlinkGC heap compaction.
4 years ago (2016-12-12 08:29:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570483002/1
4 years ago (2016-12-12 08:29:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 08:31:08 UTC) #6
sof
lgtm, thanks for the revert. It seems restricted to Mac release, I can't pick up ...
4 years ago (2016-12-12 08:34:45 UTC) #7
haraken
LGTM
4 years ago (2016-12-12 08:36:03 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88209344ccad5aa05ce1c70a77c8942bc7b20a75
Cr-Commit-Position: refs/heads/master@{#437834}

Powered by Google App Engine
This is Rietveld 408576698