Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 2531973002: Simple BlinkGC heap compaction. (Closed)

Created:
4 years ago by sof
Modified:
3 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simple BlinkGC heap compaction. This implements heap compaction for the Blink GC infrastructure (Oilpan), compacting the arenas of the BlinkGC heap which are most susceptible to becoming fragmented during actual use. Fragmentation is a real problem and a growing one while browsing anything but static pages: the amount of unused, but allocated, memory is fluctuating higher over time. To avoid leaving increasing amounts of unused holes in our heaps, heap compaction will periodically squeeze out the unused portions, packing together the live objects. The heap pages that are then left as unused, are subsequently released and returned to the OS. Due to a fortunate property of Blink heap collection types, providing such compaction is within relatively easy reach. Experiments show that the arenas which hold such collection objects ("backing stores") are the ones that develop fragmentation the most & persistently. While not a complete heap compactor of all Blink GC arenas, it addresses the fragmentation problem where it is most pressing. More can be done, later. Explainer / design document: https://docs.google.com/document/d/1k-vivOinomDXnScw8Ew5zpsYCXiYqj76OCOYZSvHkaU R=haraken BUG=672030 Committed: https://crrev.com/2c7d13f7694fa208d996947731eacd152902ebdd Cr-Commit-Position: refs/heads/master@{#438125}

Patch Set 1 #

Patch Set 2 : tidy up comment #

Total comments: 21

Patch Set 3 : synchronize on compaction finish #

Total comments: 58

Patch Set 4 : review updates #

Patch Set 5 : cros compile fix #

Total comments: 77

Patch Set 6 : review updates #

Patch Set 7 : Tidy up logging #

Patch Set 8 : add more comments #

Total comments: 68

Patch Set 9 : review updates #

Patch Set 10 : asan compile fix #

Patch Set 11 : improve assert #

Patch Set 12 : introduce compaction state context #

Patch Set 13 : fix mismerge #

Patch Set 14 : comment tidying #

Patch Set 15 : add pointer alignment handling to SparseHeapBitmap #

Total comments: 96

Patch Set 16 : handle 4 byte pointer aligns #

Patch Set 17 : rebased up to r437488 #

Patch Set 18 : review updates #

Patch Set 19 : further review updates #

Patch Set 20 : verify that lazy unmarking doesn't intersect with compactables #

Patch Set 21 : tweak assert #

Total comments: 1

Patch Set 22 : adjust copyright attributions #

Patch Set 23 : Clear unused pages before decommitting #

Total comments: 2

Patch Set 24 : leave unused pages zapped, if approp. #

Patch Set 25 : rebased upto r438110 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2022 lines, -23 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGC.h View 1 2 3 3 chunks +21 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/heap/HeapCompact.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +207 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/heap/HeapCompact.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +479 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/heap/HeapCompactTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +461 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 6 chunks +282 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 7 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitor.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/heap/SparseHeapBitmap.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +136 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/heap/SparseHeapBitmap.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +111 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 4 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 10 chunks +52 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 5 chunks +35 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/Deque.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +51 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 185 (108 generated)
sof
please take a look.
4 years ago (2016-11-28 10:29:11 UTC) #12
haraken
(Let me take a look at this tomorrow.)
4 years ago (2016-11-29 15:26:28 UTC) #13
haraken
A couple of high-level comments. https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/Heap.h File third_party/WebKit/Source/platform/heap/Heap.h (right): https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/Heap.h#newcode408 third_party/WebKit/Source/platform/heap/Heap.h:408: void registerRelocation(MovableReference* slot); What's ...
4 years ago (2016-11-30 06:29:53 UTC) #15
sof
https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/Heap.h File third_party/WebKit/Source/platform/heap/Heap.h (right): https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/Heap.h#newcode408 third_party/WebKit/Source/platform/heap/Heap.h:408: void registerRelocation(MovableReference* slot); On 2016/11/30 06:29:52, haraken wrote: > ...
4 years ago (2016-11-30 06:52:44 UTC) #16
haraken
https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp File third_party/WebKit/Source/platform/heap/HeapCompact.cpp (right): https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp#newcode53 third_party/WebKit/Source/platform/heap/HeapCompact.cpp:53: if (m_relocatablePages.contains(slotPage)) { On 2016/11/30 06:52:43, sof wrote: > ...
4 years ago (2016-11-30 07:09:49 UTC) #17
sof
https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp File third_party/WebKit/Source/platform/heap/HeapCompact.cpp (right): https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp#newcode53 third_party/WebKit/Source/platform/heap/HeapCompact.cpp:53: if (m_relocatablePages.contains(slotPage)) { On 2016/11/30 07:09:49, haraken wrote: > ...
4 years ago (2016-11-30 07:26:38 UTC) #18
haraken
https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp File third_party/WebKit/Source/platform/heap/HeapCompact.cpp (right): https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp#newcode53 third_party/WebKit/Source/platform/heap/HeapCompact.cpp:53: if (m_relocatablePages.contains(slotPage)) { On 2016/11/30 07:26:38, sof wrote: > ...
4 years ago (2016-11-30 08:51:19 UTC) #19
sof
https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp File third_party/WebKit/Source/platform/heap/HeapCompact.cpp (right): https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp#newcode53 third_party/WebKit/Source/platform/heap/HeapCompact.cpp:53: if (m_relocatablePages.contains(slotPage)) { On 2016/11/30 08:51:19, haraken wrote: > ...
4 years ago (2016-11-30 09:22:14 UTC) #20
haraken
On 2016/11/30 09:22:14, sof wrote: > https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp > File third_party/WebKit/Source/platform/heap/HeapCompact.cpp (right): > > https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp#newcode53 > ...
4 years ago (2016-11-30 09:41:11 UTC) #21
sof
https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/ThreadState.cpp File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right): https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/ThreadState.cpp#newcode1169 third_party/WebKit/Source/platform/heap/ThreadState.cpp:1169: compact(); On 2016/11/30 06:52:44, sof wrote: > On 2016/11/30 ...
4 years ago (2016-11-30 10:47:41 UTC) #22
haraken
On 2016/11/30 10:47:41, sof wrote: > https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/ThreadState.cpp > File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right): > > https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/ThreadState.cpp#newcode1169 > ...
4 years ago (2016-11-30 11:01:35 UTC) #23
haraken
Questions about the bitmap: - Are there many interior heap collections? Do you think it's ...
4 years ago (2016-11-30 11:05:13 UTC) #24
keishi
On 2016/11/30 11:01:35, haraken wrote: > On 2016/11/30 10:47:41, sof wrote: > > > https://codereview.chromium.org/2531973002/diff/20001/third_party/WebKit/Source/platform/heap/ThreadState.cpp ...
4 years ago (2016-11-30 12:12:12 UTC) #25
sof
On 2016/11/30 12:12:12, keishi wrote: > On 2016/11/30 11:01:35, haraken wrote: > > On 2016/11/30 ...
4 years ago (2016-11-30 12:14:59 UTC) #26
sof
On 2016/11/30 11:05:13, haraken wrote: > Questions about the bitmap: > > - Are there ...
4 years ago (2016-11-30 13:21:39 UTC) #27
sof
On 2016/11/30 12:14:59, sof wrote: > On 2016/11/30 12:12:12, keishi wrote: > > On 2016/11/30 ...
4 years ago (2016-11-30 14:38:10 UTC) #30
haraken
On 2016/11/30 13:21:39, sof wrote: > On 2016/11/30 11:05:13, haraken wrote: > > Questions about ...
4 years ago (2016-11-30 14:55:58 UTC) #31
sof
On 2016/11/30 14:55:58, haraken wrote: > On 2016/11/30 13:21:39, sof wrote: > > On 2016/11/30 ...
4 years ago (2016-11-30 15:10:55 UTC) #32
sof
On 2016/11/30 15:10:55, sof wrote: > On 2016/11/30 14:55:58, haraken wrote: > > On 2016/11/30 ...
4 years ago (2016-11-30 15:27:23 UTC) #33
sof
On 2016/11/30 15:27:23, sof wrote: > On 2016/11/30 15:10:55, sof wrote: ... > > > ...
4 years ago (2016-11-30 22:10:43 UTC) #36
haraken
On 2016/11/30 22:10:43, sof wrote: > On 2016/11/30 15:27:23, sof wrote: > > On 2016/11/30 ...
4 years ago (2016-12-01 09:10:05 UTC) #37
sof
On 2016/12/01 09:10:05, haraken wrote: > On 2016/11/30 22:10:43, sof wrote: > > On 2016/11/30 ...
4 years ago (2016-12-01 21:41:34 UTC) #38
haraken
On 2016/12/01 21:41:34, sof wrote: > On 2016/12/01 09:10:05, haraken wrote: > > On 2016/11/30 ...
4 years ago (2016-12-02 04:30:53 UTC) #39
sof
On 2016/12/02 04:30:53, haraken wrote: > On 2016/12/01 21:41:34, sof wrote: > > On 2016/12/01 ...
4 years ago (2016-12-02 06:41:35 UTC) #40
haraken
I have just reviewed 50% of the CL -- let me take a look at ...
4 years ago (2016-12-02 12:43:21 UTC) #41
sof
https://codereview.chromium.org/2531973002/diff/40001/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/2531973002/diff/40001/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in#newcode115 third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:115: HeapCompaction status=experimental On 2016/12/02 12:43:19, haraken wrote: > > ...
4 years ago (2016-12-04 14:55:38 UTC) #48
sof
On 2016/12/02 12:43:21, haraken wrote: > I have just reviewed 50% of the CL -- ...
4 years ago (2016-12-04 15:31:24 UTC) #49
haraken
https://codereview.chromium.org/2531973002/diff/80001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp File third_party/WebKit/Source/platform/heap/HeapCompact.cpp (right): https://codereview.chromium.org/2531973002/diff/80001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp#newcode29 third_party/WebKit/Source/platform/heap/HeapCompact.cpp:29: return std::unique_ptr<MovableObjectFixups>(new MovableObjectFixups); wrapUnique https://codereview.chromium.org/2531973002/diff/80001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp#newcode54 third_party/WebKit/Source/platform/heap/HeapCompact.cpp:54: // Slot resides ...
4 years ago (2016-12-05 11:27:47 UTC) #52
sof
Thanks for detailed review; flushing my buffer with followups to most. https://codereview.chromium.org/2531973002/diff/80001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp File third_party/WebKit/Source/platform/heap/HeapCompact.cpp (right): ...
4 years ago (2016-12-05 19:30:07 UTC) #55
sof
https://codereview.chromium.org/2531973002/diff/80001/third_party/WebKit/Source/platform/heap/HeapPage.cpp File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right): https://codereview.chromium.org/2531973002/diff/80001/third_party/WebKit/Source/platform/heap/HeapPage.cpp#newcode506 third_party/WebKit/Source/platform/heap/HeapPage.cpp:506: normalPage->sweepAndCompact(nextPage, &m_firstPage, allocationPoint); On 2016/12/05 19:30:07, sof wrote: > ...
4 years ago (2016-12-06 10:55:59 UTC) #64
haraken
I hope the next round will be the final round of review. I might want ...
4 years ago (2016-12-06 13:30:39 UTC) #67
sof
There's unit test coverage for SparseHeapBitmap already, see HeapCompactTest. I'll have to locally verify ASan ...
4 years ago (2016-12-06 21:39:35 UTC) #69
haraken
https://codereview.chromium.org/2531973002/diff/80001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp File third_party/WebKit/Source/platform/heap/HeapCompact.cpp (right): https://codereview.chromium.org/2531973002/diff/80001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp#newcode172 third_party/WebKit/Source/platform/heap/HeapCompact.cpp:172: if (UNLIKELY(it != m_interiorFixups.end() && !it->value)) On 2016/12/06 21:39:34, ...
4 years ago (2016-12-07 08:55:11 UTC) #73
sof
https://codereview.chromium.org/2531973002/diff/80001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp File third_party/WebKit/Source/platform/heap/HeapCompact.cpp (right): https://codereview.chromium.org/2531973002/diff/80001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp#newcode172 third_party/WebKit/Source/platform/heap/HeapCompact.cpp:172: if (UNLIKELY(it != m_interiorFixups.end() && !it->value)) On 2016/12/07 08:55:11, ...
4 years ago (2016-12-07 10:45:08 UTC) #76
haraken
(I might be busy tomorrow -- will do the final scanning on Friday.) https://codereview.chromium.org/2531973002/diff/140001/third_party/WebKit/Source/platform/heap/HeapCompact.cpp File ...
4 years ago (2016-12-07 12:44:33 UTC) #80
sof
https://codereview.chromium.org/2531973002/diff/140001/third_party/WebKit/Source/platform/heap/HeapPage.cpp File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right): https://codereview.chromium.org/2531973002/diff/140001/third_party/WebKit/Source/platform/heap/HeapPage.cpp#newcode521 third_party/WebKit/Source/platform/heap/HeapPage.cpp:521: // into. On 2016/12/07 12:44:33, haraken wrote: > On ...
4 years ago (2016-12-07 13:01:59 UTC) #81
haraken
https://codereview.chromium.org/2531973002/diff/140001/third_party/WebKit/Source/platform/heap/HeapPage.cpp File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right): https://codereview.chromium.org/2531973002/diff/140001/third_party/WebKit/Source/platform/heap/HeapPage.cpp#newcode521 third_party/WebKit/Source/platform/heap/HeapPage.cpp:521: // into. On 2016/12/07 13:01:59, sof wrote: > On ...
4 years ago (2016-12-07 15:45:53 UTC) #82
sof
https://codereview.chromium.org/2531973002/diff/140001/third_party/WebKit/Source/platform/heap/HeapPage.cpp File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right): https://codereview.chromium.org/2531973002/diff/140001/third_party/WebKit/Source/platform/heap/HeapPage.cpp#newcode521 third_party/WebKit/Source/platform/heap/HeapPage.cpp:521: // into. On 2016/12/07 15:45:53, haraken wrote: > On ...
4 years ago (2016-12-07 22:37:25 UTC) #87
haraken
LGTM! https://codereview.chromium.org/2531973002/diff/40001/third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h File third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h (right): https://codereview.chromium.org/2531973002/diff/40001/third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h#newcode65 third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h:65: const Visitor::MarkingMode m_markingMode; On 2016/12/04 14:55:38, sof wrote: ...
4 years ago (2016-12-09 07:25:57 UTC) #102
haraken
(I think this is the most complicated CL I've reviewed this year :-)
4 years ago (2016-12-09 07:26:46 UTC) #103
sof
On 2016/12/09 07:26:46, haraken wrote: > (I think this is the most complicated CL I've ...
4 years ago (2016-12-09 07:36:49 UTC) #104
haraken
If you want me to run a Finch experiment (enable the feature on a certain ...
4 years ago (2016-12-09 07:39:13 UTC) #105
sof
On 2016/12/09 07:39:13, haraken wrote: > If you want me to run a Finch experiment ...
4 years ago (2016-12-09 08:01:42 UTC) #106
sof
That's about it, I hope. https://codereview.chromium.org/2531973002/diff/40001/third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h File third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h (right): https://codereview.chromium.org/2531973002/diff/40001/third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h#newcode65 third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h:65: const Visitor::MarkingMode m_markingMode; On ...
4 years ago (2016-12-09 21:44:05 UTC) #120
sof
https://codereview.chromium.org/2531973002/diff/400001/third_party/WebKit/Source/platform/heap/HeapCompact.h File third_party/WebKit/Source/platform/heap/HeapCompact.h (right): https://codereview.chromium.org/2531973002/diff/400001/third_party/WebKit/Source/platform/heap/HeapCompact.h#newcode1 third_party/WebKit/Source/platform/heap/HeapCompact.h:1: // Copyright 2016 Opera Software AS. All rights reserved. ...
4 years ago (2016-12-10 07:50:54 UTC) #125
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531973002/420001
4 years ago (2016-12-11 20:03:35 UTC) #131
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/196736)
4 years ago (2016-12-11 22:10:26 UTC) #133
haraken
Still LGTM https://codereview.chromium.org/2531973002/diff/280001/third_party/WebKit/Source/platform/heap/HeapTest.cpp File third_party/WebKit/Source/platform/heap/HeapTest.cpp (right): https://codereview.chromium.org/2531973002/diff/280001/third_party/WebKit/Source/platform/heap/HeapTest.cpp#newcode3774 third_party/WebKit/Source/platform/heap/HeapTest.cpp:3774: ThreadState::GCForbiddenScope gcScope(ThreadState::current()); On 2016/12/09 21:44:04, sof wrote: ...
4 years ago (2016-12-12 01:25:10 UTC) #134
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531973002/420001
4 years ago (2016-12-12 06:21:18 UTC) #136
commit-bot: I haz the power
Committed patchset #22 (id:420001)
4 years ago (2016-12-12 07:13:07 UTC) #139
yhirano
A revert of this CL (patchset #22 id:420001) has been created in https://codereview.chromium.org/2570483002/ by yhirano@chromium.org. ...
4 years ago (2016-12-12 08:29:26 UTC) #140
grt (UTC plus 2)
On 2016/12/12 08:29:26, yhirano wrote: > A revert of this CL (patchset #22 id:420001) has ...
4 years ago (2016-12-12 08:35:56 UTC) #141
sof
On 2016/12/12 08:35:56, grt (UTC plus 1) wrote: > On 2016/12/12 08:29:26, yhirano wrote: > ...
4 years ago (2016-12-12 09:18:25 UTC) #143
sof
On 2016/12/12 09:18:25, sof wrote: > On 2016/12/12 08:35:56, grt (UTC plus 1) wrote: > ...
4 years ago (2016-12-12 10:51:04 UTC) #144
commit-bot: I haz the power
Patchset 22 (id:??) landed as https://crrev.com/c55a2886f98771ade1d73b99d21464c517b5e11e Cr-Commit-Position: refs/heads/master@{#437829}
4 years ago (2016-12-12 15:11:00 UTC) #146
sof
On 2016/12/12 10:51:04, sof wrote: > On 2016/12/12 09:18:25, sof wrote: > > On 2016/12/12 ...
4 years ago (2016-12-12 15:31:29 UTC) #147
sof
On 2016/12/12 15:31:29, sof wrote: > On 2016/12/12 10:51:04, sof wrote: > > On 2016/12/12 ...
4 years ago (2016-12-12 19:53:55 UTC) #151
haraken
Nice detective work! LGTM. https://codereview.chromium.org/2531973002/diff/440001/third_party/WebKit/Source/platform/heap/HeapPage.cpp File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right): https://codereview.chromium.org/2531973002/diff/440001/third_party/WebKit/Source/platform/heap/HeapPage.cpp#newcode572 third_party/WebKit/Source/platform/heap/HeapPage.cpp:572: memset(unusedPage->payload(), 0, unusedPage->payloadSize()); This should ...
4 years ago (2016-12-13 02:29:41 UTC) #154
sof
https://codereview.chromium.org/2531973002/diff/440001/third_party/WebKit/Source/platform/heap/HeapPage.cpp File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right): https://codereview.chromium.org/2531973002/diff/440001/third_party/WebKit/Source/platform/heap/HeapPage.cpp#newcode572 third_party/WebKit/Source/platform/heap/HeapPage.cpp:572: memset(unusedPage->payload(), 0, unusedPage->payloadSize()); On 2016/12/13 02:29:41, haraken wrote: > ...
4 years ago (2016-12-13 06:18:31 UTC) #157
haraken
On 2016/12/13 06:18:31, sof wrote: > https://codereview.chromium.org/2531973002/diff/440001/third_party/WebKit/Source/platform/heap/HeapPage.cpp > File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right): > > https://codereview.chromium.org/2531973002/diff/440001/third_party/WebKit/Source/platform/heap/HeapPage.cpp#newcode572 > ...
4 years ago (2016-12-13 06:19:18 UTC) #158
sof
Relanding. trybot results are fine + verified mac release (no dchecks) status via https://codereview.chromium.org/2566973002/
4 years ago (2016-12-13 09:21:56 UTC) #162
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531973002/460001
4 years ago (2016-12-13 09:22:39 UTC) #164
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-13 09:28:08 UTC) #166
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531973002/480001
4 years ago (2016-12-13 09:37:25 UTC) #169
commit-bot: I haz the power
Committed patchset #25 (id:480001)
4 years ago (2016-12-13 11:34:08 UTC) #172
commit-bot: I haz the power
Patchset 25 (id:??) landed as https://crrev.com/2c7d13f7694fa208d996947731eacd152902ebdd Cr-Commit-Position: refs/heads/master@{#438125}
4 years ago (2016-12-13 11:36:21 UTC) #174
agrieve
On 2016/12/13 11:36:21, commit-bot: I haz the power wrote: > Patchset 25 (id:??) landed as ...
4 years ago (2016-12-13 18:46:39 UTC) #175
haraken
jbroman@ pointed out that the heap compaction will make code that caches an inteator unsafe: ...
4 years ago (2016-12-14 04:29:05 UTC) #176
sof
On 2016/12/14 04:29:05, haraken wrote: > jbroman@ pointed out that the heap compaction will make ...
4 years ago (2016-12-14 07:58:44 UTC) #177
haraken
On 2016/12/14 07:58:44, sof wrote: > On 2016/12/14 04:29:05, haraken wrote: > > jbroman@ pointed ...
4 years ago (2016-12-14 08:11:59 UTC) #178
haraken
FWIW, a holiday season would be a good timing to experiment with enabling this kind ...
4 years ago (2016-12-19 04:48:37 UTC) #179
sof
On 2016/12/14 08:11:59, haraken wrote: > On 2016/12/14 07:58:44, sof wrote: > > On 2016/12/14 ...
4 years ago (2016-12-20 13:04:30 UTC) #180
sof
On 2016/12/19 04:48:37, haraken wrote: > FWIW, a holiday season would be a good timing ...
4 years ago (2016-12-20 13:15:23 UTC) #181
haraken
On 2016/12/20 13:15:23, sof wrote: > On 2016/12/19 04:48:37, haraken wrote: > > FWIW, a ...
4 years ago (2016-12-21 05:17:46 UTC) #182
sof
On 2016/12/21 05:17:46, haraken wrote: > On 2016/12/20 13:15:23, sof wrote: > > On 2016/12/19 ...
4 years ago (2016-12-23 10:02:37 UTC) #183
sof
On 2016/12/23 10:02:37, sof wrote: > On 2016/12/21 05:17:46, haraken wrote: > > On 2016/12/20 ...
3 years, 11 months ago (2017-01-03 19:14:14 UTC) #184
agrieve
3 years, 11 months ago (2017-01-17 21:49:07 UTC) #185
Message was sent while issue was closed.
On 2016/12/13 18:46:39, agrieve wrote:
> On 2016/12/13 11:36:21, commit-bot: I haz the power wrote:
> > Patchset 25 (id:??) landed as
> > https://crrev.com/2c7d13f7694fa208d996947731eacd152902ebdd
> > Cr-Commit-Position: refs/heads/master@{#438125}
> 
> Note: This increased libchrome.so on Android by 180kb (not saying any action
is
> required, but wanted to have this information attached to this review)
> 
> Graph link:
>
https://chromeperf.appspot.com/report?sid=473d6bf7347eaebc0a34c09b2f564f4d205...

FYI - going to investigate size bloat in
https://bugs.chromium.org/p/chromium/issues/detail?id=681991

Powered by Google App Engine
This is Rietveld 408576698