Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: third_party/WebKit/Source/platform/heap/Visitor.cpp

Issue 2570483002: Revert of Simple BlinkGC heap compaction. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/heap/Visitor.h" 5 #include "platform/heap/Visitor.h"
6 6
7 #include "platform/heap/BlinkGC.h" 7 #include "platform/heap/BlinkGC.h"
8 #include "platform/heap/MarkingVisitor.h" 8 #include "platform/heap/MarkingVisitor.h"
9 #include "platform/heap/ThreadState.h" 9 #include "platform/heap/ThreadState.h"
10 #include "wtf/PtrUtil.h" 10 #include "wtf/PtrUtil.h"
11 #include <memory> 11 #include <memory>
12 12
13 namespace blink { 13 namespace blink {
14 14
15 std::unique_ptr<Visitor> Visitor::create(ThreadState* state, 15 std::unique_ptr<Visitor> Visitor::create(ThreadState* state,
16 BlinkGC::GCType gcType) { 16 BlinkGC::GCType gcType) {
17 switch (gcType) { 17 switch (gcType) {
18 case BlinkGC::GCWithSweep: 18 case BlinkGC::GCWithSweep:
19 case BlinkGC::GCWithoutSweep: 19 case BlinkGC::GCWithoutSweep:
20 return WTF::makeUnique<MarkingVisitor<Visitor::GlobalMarking>>(state); 20 return WTF::makeUnique<MarkingVisitor<Visitor::GlobalMarking>>(state);
21 case BlinkGC::GCWithSweepCompaction:
22 return WTF::makeUnique<
23 MarkingVisitor<Visitor::GlobalMarkingWithCompaction>>(state);
24 case BlinkGC::TakeSnapshot: 21 case BlinkGC::TakeSnapshot:
25 return WTF::makeUnique<MarkingVisitor<Visitor::SnapshotMarking>>(state); 22 return WTF::makeUnique<MarkingVisitor<Visitor::SnapshotMarking>>(state);
26 case BlinkGC::ThreadTerminationGC: 23 case BlinkGC::ThreadTerminationGC:
27 return WTF::makeUnique<MarkingVisitor<Visitor::ThreadLocalMarking>>( 24 return WTF::makeUnique<MarkingVisitor<Visitor::ThreadLocalMarking>>(
28 state); 25 state);
29 case BlinkGC::ThreadLocalWeakProcessing: 26 case BlinkGC::ThreadLocalWeakProcessing:
30 return WTF::makeUnique<MarkingVisitor<Visitor::WeakProcessing>>(state); 27 return WTF::makeUnique<MarkingVisitor<Visitor::WeakProcessing>>(state);
31 default: 28 default:
32 ASSERT_NOT_REACHED(); 29 ASSERT_NOT_REACHED();
33 } 30 }
34 return nullptr; 31 return nullptr;
35 } 32 }
36 33
37 Visitor::Visitor(ThreadState* state, MarkingMode markingMode) 34 Visitor::Visitor(ThreadState* state, MarkingMode markingMode)
38 : VisitorHelper(state), m_markingMode(markingMode) { 35 : VisitorHelper(state), m_markingMode(markingMode) {
39 // See ThreadState::runScheduledGC() why we need to already be in a 36 // See ThreadState::runScheduledGC() why we need to already be in a
40 // GCForbiddenScope before any safe point is entered. 37 // GCForbiddenScope before any safe point is entered.
41 DCHECK(state->isGCForbidden()); 38 state->enterGCForbiddenScope();
42 #if ENABLE(ASSERT) 39
43 DCHECK(state->checkThread()); 40 ASSERT(state->checkThread());
44 #endif
45 } 41 }
46 42
47 Visitor::~Visitor() {} 43 Visitor::~Visitor() {
44 state()->leaveGCForbiddenScope();
45 }
48 46
49 } // namespace blink 47 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/heap/Visitor.h ('k') | third_party/WebKit/Source/wtf/Deque.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698