Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.h

Issue 2570483002: Revert of Simple BlinkGC heap compaction. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/ThreadState.h
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.h b/third_party/WebKit/Source/platform/heap/ThreadState.h
index bca31e27980e07554607cab516bc2a3a9cb5c464..6ab0903e33f4eadf0e9522dd9c5c20d40233d7cb 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.h
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.h
@@ -284,8 +284,6 @@
// the executions of mutators.
void makeConsistentForMutator();
- void compact();
-
// Support for disallowing allocation. Mainly used for sanity
// checks asserts.
bool isAllocationAllowed() const {
@@ -319,20 +317,6 @@
m_threadState->enterGCForbiddenScope();
}
~MainThreadGCForbiddenScope() { m_threadState->leaveGCForbiddenScope(); }
-
- private:
- ThreadState* const m_threadState;
- };
-
- class GCForbiddenScope final {
- STACK_ALLOCATED();
-
- public:
- explicit GCForbiddenScope(ThreadState* threadState)
- : m_threadState(threadState) {
- m_threadState->enterGCForbiddenScope();
- }
- ~GCForbiddenScope() { m_threadState->leaveGCForbiddenScope(); }
private:
ThreadState* const m_threadState;
@@ -577,13 +561,9 @@
v8::Isolate* isolate() const { return m_isolate; }
- BlinkGC::StackState stackState() const { return m_stackState; }
-
void collectGarbage(BlinkGC::StackState, BlinkGC::GCType, BlinkGC::GCReason);
void collectGarbageForTerminatingThread();
void collectAllGarbage();
-
- static const char* gcReasonString(BlinkGC::GCReason);
private:
enum SnapshotType { HeapSnapshot, FreelistSnapshot };
« no previous file with comments | « third_party/WebKit/Source/platform/heap/SparseHeapBitmap.cpp ('k') | third_party/WebKit/Source/platform/heap/ThreadState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698