Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: third_party/WebKit/Source/platform/heap/Heap.h

Issue 2570483002: Revert of Simple BlinkGC heap compaction. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/BlinkGC.h ('k') | third_party/WebKit/Source/platform/heap/Heap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/Heap.h
diff --git a/third_party/WebKit/Source/platform/heap/Heap.h b/third_party/WebKit/Source/platform/heap/Heap.h
index 846f71a08f412faaf55a88261d9f9a7efb5ac0fc..b02aa40e4b2e6110da6cbba0741dca57fb291d54 100644
--- a/third_party/WebKit/Source/platform/heap/Heap.h
+++ b/third_party/WebKit/Source/platform/heap/Heap.h
@@ -81,7 +81,6 @@
};
class CrossThreadPersistentRegion;
-class HeapCompact;
template <typename T>
class Member;
template <typename T>
@@ -382,27 +381,6 @@
bool weakTableRegistered(const void*);
#endif
- // Heap compaction registration methods:
-
- // Register |slot| as containing a reference to a movable heap object.
- //
- // When compaction moves the object pointed to by |*slot| to |newAddress|,
- // |*slot| must be updated to hold |newAddress| instead.
- void registerMovingObjectReference(MovableReference*);
-
- // Register a callback to be invoked upon moving the object starting at
- // |reference|; see |MovingObjectCallback| documentation for details.
- //
- // This callback mechanism is needed to account for backing store objects
- // containing intra-object pointers, all of which must be relocated/rebased
- // with respect to the moved-to location.
- //
- // For Blink, |HeapLinkedHashSet<>| is currently the only abstraction which
- // relies on this feature.
- void registerMovingObjectCallback(MovableReference,
- MovingObjectCallback,
- void* callbackData);
-
BlinkGC::GCReason lastGCReason() { return m_lastGCReason; }
RegionTree* getRegionTree() { return m_regionTree.get(); }
@@ -459,8 +437,6 @@
static void reportMemoryUsageHistogram();
static void reportMemoryUsageForTracing();
-
- HeapCompact* compaction();
private:
// Reset counters that track live and allocated-since-last-GC sizes.
@@ -486,8 +462,6 @@
std::unique_ptr<CallbackStack> m_ephemeronStack;
BlinkGC::GCReason m_lastGCReason;
StackFrameDepth m_stackFrameDepth;
-
- std::unique_ptr<HeapCompact> m_compaction;
static ThreadHeap* s_mainThreadHeap;
« no previous file with comments | « third_party/WebKit/Source/platform/heap/BlinkGC.h ('k') | third_party/WebKit/Source/platform/heap/Heap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698