Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2570453002: Add CHECKs to investigate ServiceWorkerControlleeRequestHandler crash. (Closed)

Created:
4 years ago by falken
Modified:
4 years ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CHECKs to investigate ServiceWorkerControlleeRequestHandler crash. If the crash still occurs and the CHECKs pass, we know the null active version is due to SWRegistration::DeleteVersion. BUG=655910 Committed: https://crrev.com/19acb64c7a3652a16d9989fe28c40182a7b2558a Cr-Commit-Position: refs/heads/master@{#437830}

Patch Set 1 #

Patch Set 2 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
falken
ptal
4 years ago (2016-12-12 04:55:31 UTC) #4
horo
4 years ago (2016-12-12 07:26:15 UTC) #9
horo
lgtm
4 years ago (2016-12-12 07:26:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570453002/20001
4 years ago (2016-12-12 07:30:49 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 07:34:50 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:02 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19acb64c7a3652a16d9989fe28c40182a7b2558a
Cr-Commit-Position: refs/heads/master@{#437830}

Powered by Google App Engine
This is Rietveld 408576698