content/browser/service_worker/service_worker_registration.cc - Issue 2570453002: Add CHECKs to investigate ServiceWorkerControlleeRequestHandler crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 2570453002: Add CHECKs to investigate ServiceWorkerControlleeRequestHandler crash. (Closed)

Patch Set: fix compile Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_registration.cc

diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc

index c3e2b7842e62c1d2ced57dbdcd018eeba8cae9e2..3c550eef28a013c3049c1334ff7cc27708372349 100644

--- a/content/browser/service_worker/service_worker_registration.cc

+++ b/content/browser/service_worker/service_worker_registration.cc

@@ -357,7 +357,7 @@ void ServiceWorkerRegistration::DeleteVersion(

!it->IsAtEnd(); it->Advance()) {

ServiceWorkerProviderHost* host = it->GetProviderHost();

if (host->controlling_version() == version)

- host->NotifyControllerLost();

+ host->NotifyControllerLost(true /* was_deleted */);

}

version->Doom();