Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 2570453002: Add CHECKs to investigate ServiceWorkerControlleeRequestHandler crash. (Closed)
Patch Set: fix compile Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_provider_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_controllee_request_handler.cc
diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc
index 93dd303945c63b2d5a9685b0a20af34ab7bb01a4..c545c6d33cfa355b365948a1a19279f5a185e64c 100644
--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc
+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc
@@ -404,7 +404,13 @@ void ServiceWorkerControlleeRequestHandler::OnUpdatedVersionStatusChanged(
void ServiceWorkerControlleeRequestHandler::PrepareForSubResource() {
DCHECK(job_.get());
DCHECK(context_);
- DCHECK(provider_host_->active_version());
+
+ if (!provider_host_->active_version()) {
+ // TODO(falken): For debugging. Remove once https://crbug.com/655910 is
+ // resolved.
+ CHECK(provider_host_->controller_was_deleted());
+ }
+
MaybeForwardToServiceWorker(job_.get(), provider_host_->active_version());
}
@@ -441,7 +447,7 @@ bool ServiceWorkerControlleeRequestHandler::RequestStillValid(
void ServiceWorkerControlleeRequestHandler::MainResourceLoadFailed() {
DCHECK(provider_host_);
// Detach the controller so subresource requests also skip the worker.
- provider_host_->NotifyControllerLost();
+ provider_host_->NotifyControllerLost(false /* was_deleted */);
}
void ServiceWorkerControlleeRequestHandler::ClearJob() {
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_provider_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698