Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11825)

Unified Diff: content/browser/service_worker/service_worker_provider_host.h

Issue 2570453002: Add CHECKs to investigate ServiceWorkerControlleeRequestHandler crash. (Closed)
Patch Set: fix compile Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.h
diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h
index 3cfc6eabdb63e83c8821520bd865f4a74fec5954..9db2711c09c18c29de6b3db1221f3c6f31ab7f40 100644
--- a/content/browser/service_worker/service_worker_provider_host.h
+++ b/content/browser/service_worker/service_worker_provider_host.h
@@ -259,7 +259,8 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
// Called when our controller has been terminated and doomed due to an
// exceptional condition like it could no longer be read from the script
// cache.
- void NotifyControllerLost();
+ void NotifyControllerLost(bool was_deleted);
+ bool controller_was_deleted() { return controller_was_deleted_; }
private:
friend class ForeignFetchRequestHandlerTest;
@@ -373,6 +374,8 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
base::WeakPtr<ServiceWorkerContextCore> context_;
ServiceWorkerDispatcherHost* dispatcher_host_;
bool allow_association_;
+ // TODO(falken): Remove once https://crbug.com/655910 is resolved.
+ bool controller_was_deleted_;
std::vector<base::Closure> queued_events_;

Powered by Google App Engine
This is Rietveld 408576698